Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix legacy reset behavior #17270

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Fix legacy reset behavior #17270

merged 1 commit into from
Sep 27, 2022

Conversation

gosusnp
Copy link
Contributor

@gosusnp gosusnp commented Sep 27, 2022

What

  • Fix how we force an old version of a connector in the tests, scope was too narrow, we were discovering schema using a different version of the connector
  • Fix reset endpoint behavior, State NOT_SET should be same as LEGACY

@gosusnp
Fix legacy reset behavior
c0854aa 
* Fix how we force an old version of a connector in the tests
* Fix endpoint behavior, State NOT_SET should be same as LEGACY
@github-actions github-actions bot added area/platform issues related to the platform area/server labels Sep 27, 2022
@gosusnp gosusnp requested a review from benmoriceau September 27, 2022 18:14
@gosusnp gosusnp merged commit f16b1eb into master Sep 27, 2022
@gosusnp gosusnp deleted the gosusnp/freeze-pg-version-for-legacy-tests branch September 27, 2022 18:48
This was referenced Sep 27, 2022
Closed
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@gosusnp @robbinhan
Fix legacy reset behavior (airbytehq#17270)
a2a9903 
* Fix how we force an old version of a connector in the tests
* Fix endpoint behavior, State NOT_SET should be same as LEGACY
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@gosusnp @jhammarstedt
Fix legacy reset behavior (airbytehq#17270)
cf91570 
* Fix how we force an old version of a connector in the tests
* Fix endpoint behavior, State NOT_SET should be same as LEGACY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmoriceau benmoriceau benmoriceau approved these changes

@subodh1810 subodh1810 subodh1810 approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform area/server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gosusnp @benmoriceau @subodh1810