Add db-specific quoting for non-simple names in AbstractJbdcSource #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
requested review from
michel-tricot,
sherifnada,
ChristopheDuong and
jrhizor
sherifnada
approved these changes
Jan 26, 2021
michel-tricot
approved these changes
Jan 26, 2021
| * @return quoted identifier | ||
| * @throws SQLException throws if there are any issues fulling the quoting metadata from the db. | ||
| */ | ||
| public static String enquoteIdentifier(Connection connection, String identifier) throws SQLException { |
There was a problem hiding this comment.
why not call it quoteIdentifier?
There was a problem hiding this comment.
i was matching the names that jdbc uses. no preference though. quoteIdentifier works for me.
There was a problem hiding this comment.
If you're following an existing convention, let's stick to it.
| * @return quoted identifiers | ||
| * @throws SQLException throws if there are any issues fulling the quoting metadata from the db. | ||
| */ | ||
| public static String enquoteIdentifierList(Connection connection, List<String> identifiers) throws SQLException { |
ChristopheDuong
approved these changes
Jan 26, 2021
cgardens
force-pushed
the
cgardens/mysql_quoting
branch
2 times, most recently
from
e463fa7 to
1439eaa
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
closes #1818
closes #1816
AbstractJdbcSourcedid not handle tables and columns with non alphanumeric characters (e.g. spaces, ., etc)How
I am not particularly interested in merging this before the launch. We can launch after. (unless any reviewer particularly want it right now.)