Try to make one query to DB to retrieve primary keys #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopheDuong
changed the title
cgardens
approved these changes
Mar 18, 2021
| * If @param tableName is not specified, this function may fail on some databases (for example | ||
| * MySql) but works on others (for instance Postgres) | ||
| */ | ||
| private Map<String, List<String>> discoverPrimaryKeys(JdbcDatabase database, |
There was a problem hiding this comment.
got it. i'd suggest 1 of 3 options here:
- have this return an optional if the query doesn't work
- have this method always succeed by hiding this logic internally. So it always takes the table names. If it doesn't need them it doesn't use them, but if it does it has them.
e.g.discoverPrimaryKeys(JdbcDatabase database, Optional<String> databaseOptional, Optional<String> schemaOptional, String tableName)=>discoverPrimaryKeys(JdbcDatabase database, Optional<String> databaseOptional, Optional<String> schemaOptional, List<String> tableNames) - just always query one table at a time.
i think 2 or 3 are equally good options and are clearer than 1. with the weird quirk you discovered that you can't always use null for getPrimaryKeys it's not the end of the world if we just do a query per table.
|
Thanks for following up on this. I think you can make the contract on one method a little clearer. Otherwise good. |
jrhizor
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Follow-up on #2488 after comments: #2488 (comment)