Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests of connectors related to sync modes required #2688

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Fix integration tests of connectors related to sync modes required #2688

merged 1 commit into from
Apr 1, 2021

Conversation

ChristopheDuong
Copy link
Contributor

@ChristopheDuong ChristopheDuong commented Mar 31, 2021 •
edited
Loading

What

Following-up on #2500 integrations tests of connectors are broken as these fields are now required in configured catalogs.
(the migration script doesn't affect the files checked into the git repository)

How

Add sync_mode and destination_sync_mode to all configured_catalog.json used for tests

Pre-merge Checklist

  • Run integration tests

@auto-assign auto-assign bot requested review from davinchia and sherifnada March 31, 2021 13:36
@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-google-sheets

🕑 source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/705225067
✅ source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/705225067

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-appsflyer-singer

🕑 source-appsflyer-singer https://github.com/airbytehq/airbyte/actions/runs/705284171
❌ source-appsflyer-singer https://github.com/airbytehq/airbyte/actions/runs/705284171

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-appstore-singer

🕑 source-appstore-singer https://github.com/airbytehq/airbyte/actions/runs/705284724
✅ source-appstore-singer https://github.com/airbytehq/airbyte/actions/runs/705284724

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-braintree-singer

🕑 source-braintree-singer https://github.com/airbytehq/airbyte/actions/runs/705284836
✅ source-braintree-singer https://github.com/airbytehq/airbyte/actions/runs/705284836

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-drift

🕑 source-drift https://github.com/airbytehq/airbyte/actions/runs/705284804
❌ source-drift https://github.com/airbytehq/airbyte/actions/runs/705284804

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-exchangeratesapi-singer

🕑 source-exchangeratesapi-singer https://github.com/airbytehq/airbyte/actions/runs/705285320
✅ source-exchangeratesapi-singer https://github.com/airbytehq/airbyte/actions/runs/705285320

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/705282130
❌ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/705282130

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-file

🕑 source-file https://github.com/airbytehq/airbyte/actions/runs/705285892
✅ source-file https://github.com/airbytehq/airbyte/actions/runs/705285892

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-freshdesk

🕑 source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/705285364
✅ source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/705285364

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-github-singer

🕑 source-github-singer https://github.com/airbytehq/airbyte/actions/runs/705286162
✅ source-github-singer https://github.com/airbytehq/airbyte/actions/runs/705286162

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-gitlab-singer

🕑 source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/705285959
✅ source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/705285959

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-google-adwords-singer

🕑 source-google-adwords-singer https://github.com/airbytehq/airbyte/actions/runs/705285882
❌ source-google-adwords-singer https://github.com/airbytehq/airbyte/actions/runs/705285882

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-google-directory

🕑 source-google-directory https://github.com/airbytehq/airbyte/actions/runs/705288733
❌ source-google-directory https://github.com/airbytehq/airbyte/actions/runs/705288733

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-googleanalytics-singer

🕑 source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/705283847
❌ source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/705283847

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-greenhouse

🕑 source-greenhouse https://github.com/airbytehq/airbyte/actions/runs/705286627
❌ source-greenhouse https://github.com/airbytehq/airbyte/actions/runs/705286627

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-http-request

🕑 source-http-request https://github.com/airbytehq/airbyte/actions/runs/705283721
✅ source-http-request https://github.com/airbytehq/airbyte/actions/runs/705283721

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-hubspot

🕑 source-hubspot https://github.com/airbytehq/airbyte/actions/runs/705287336
✅ source-hubspot https://github.com/airbytehq/airbyte/actions/runs/705287336

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-instagram

🕑 source-instagram https://github.com/airbytehq/airbyte/actions/runs/705286164
❌ source-instagram https://github.com/airbytehq/airbyte/actions/runs/705286164

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-intercom-singer

🕑 source-intercom-singer https://github.com/airbytehq/airbyte/actions/runs/705287240
✅ source-intercom-singer https://github.com/airbytehq/airbyte/actions/runs/705287240

@ChristopheDuong
Copy link
Contributor Author

/test connector=source-jira

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-looker

🕑 source-looker https://github.com/airbytehq/airbyte/actions/runs/705287662
✅ source-looker https://github.com/airbytehq/airbyte/actions/runs/705287662

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-mailchimp

🕑 source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/705288007
✅ source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/705288007

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-marketo-singer

🕑 source-marketo-singer https://github.com/airbytehq/airbyte/actions/runs/705285388
✅ source-marketo-singer https://github.com/airbytehq/airbyte/actions/runs/705285388

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-microsoft-teams

🕑 source-microsoft-teams https://github.com/airbytehq/airbyte/actions/runs/705291009
✅ source-microsoft-teams https://github.com/airbytehq/airbyte/actions/runs/705291009

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-mixpanel-singer

🕑 source-mixpanel-singer https://github.com/airbytehq/airbyte/actions/runs/705285428
❌ source-mixpanel-singer https://github.com/airbytehq/airbyte/actions/runs/705285428

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-mongodb

🕑 source-mongodb https://github.com/airbytehq/airbyte/actions/runs/705288173
✅ source-mongodb https://github.com/airbytehq/airbyte/actions/runs/705288173

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-plaid

🕑 source-plaid https://github.com/airbytehq/airbyte/actions/runs/705285700
❌ source-plaid https://github.com/airbytehq/airbyte/actions/runs/705285700

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-recurly

🕑 source-recurly https://github.com/airbytehq/airbyte/actions/runs/705288775
✅ source-recurly https://github.com/airbytehq/airbyte/actions/runs/705288775

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-salesforce-singer

🕑 source-salesforce-singer https://github.com/airbytehq/airbyte/actions/runs/705286503
❌ source-salesforce-singer https://github.com/airbytehq/airbyte/actions/runs/705286503

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-scaffold-source-python

🕑 source-scaffold-source-python https://github.com/airbytehq/airbyte/actions/runs/705288905
❌ source-scaffold-source-python https://github.com/airbytehq/airbyte/actions/runs/705288905

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-sendgrid

🕑 source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/705289981
✅ source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/705289981

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-shopify-singer

🕑 source-shopify-singer https://github.com/airbytehq/airbyte/actions/runs/705291765
✅ source-shopify-singer https://github.com/airbytehq/airbyte/actions/runs/705291765

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-slack-singer

🕑 source-slack-singer https://github.com/airbytehq/airbyte/actions/runs/705288936
✅ source-slack-singer https://github.com/airbytehq/airbyte/actions/runs/705288936

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-stock-ticker-api-tutorial

🕑 source-stock-ticker-api-tutorial https://github.com/airbytehq/airbyte/actions/runs/705286653
❌ source-stock-ticker-api-tutorial https://github.com/airbytehq/airbyte/actions/runs/705286653

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe-singer

🕑 source-stripe-singer https://github.com/airbytehq/airbyte/actions/runs/705292436
✅ source-stripe-singer https://github.com/airbytehq/airbyte/actions/runs/705292436

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-tempo

🕑 source-tempo https://github.com/airbytehq/airbyte/actions/runs/705289714
✅ source-tempo https://github.com/airbytehq/airbyte/actions/runs/705289714

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-twilio-singer

🕑 source-twilio-singer https://github.com/airbytehq/airbyte/actions/runs/705286782
✅ source-twilio-singer https://github.com/airbytehq/airbyte/actions/runs/705286782

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 31, 2021 •
edited by github-actions bot
Loading

/test connector=source-zoom-singer

🕑 source-zoom-singer https://github.com/airbytehq/airbyte/actions/runs/705287944
✅ source-zoom-singer https://github.com/airbytehq/airbyte/actions/runs/705287944

@ChristopheDuong ChristopheDuong merged commit bc1547f into master Apr 1, 2021
@ChristopheDuong ChristopheDuong deleted the chris/fix-tests-requiring-sync-modes branch April 1, 2021 07:58
@Zirochkaa Zirochkaa mentioned this pull request May 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@davinchia davinchia davinchia approved these changes

Assignees
No one assigned
Labels
connectors/source/appstore-singer connectors/source/facebook-marketing connectors/source/freshdesk connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ChristopheDuong @sherifnada @davinchia @karinakuz @igrankova @ycherniaiev