feat(Airbyte CDK): add with_json_schema method to ConfiguredAirbyteStreamBuilder #40737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
maxi297
reviewed
Jul 4, 2024
octavia-squidington-iii
added
area/connectors
aldogonzalez8
force-pushed
the
aldogonzalez8/add_json_schema_to_builder
branch
from
c603551 to
a5a6382
Compare
maxi297
approved these changes
Jul 4, 2024
airbyte-cdk/python/unit_tests/sources/mock_server_tests/test_resumable_full_refresh.py
Outdated
Show resolved
Hide resolved
…Catalog instead of CatalogBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add with_json_schema method to ConfiguredAirbyteStreamBuilder to easily update json_schema Stream for testing purposes.
Relates to:
How
Add method and some unit testing around this change.
Review guide
airbyte-cdk/python/airbyte_cdk/test/catalog_builder.py: newwith_json_schemaand some changes in ConnectorBuilderwith_streammethod to accept json_schema field.airbyte-cdk/python/unit_tests/sources/mock_server_tests/test_resumable_full_refresh.py: I removed the CatalogBuilder dependency that will be deprecated and used ConfiguredAirbyteCatalog including thewith_json_schemaoption of the builder.User Impact
No user impact
Can this PR be safely reverted and rolled back?