Source Okta: Update spec for making domain field mandatory #48751
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
1 task
|
@btkcodedev rebase this and ping me on Slack, let's merge this in. |
|
Who’s helping you with the review! I want to make sure this does not go stale. |
|
/format-fix
|
|
Yep, I was about to reach out to you after CI is green |
…bytehq/airbyte into btkcodedev/fix/oktaparameter
|
@natikgadzhi It's ready for review. |
natikgadzhi
approved these changes
Jan 29, 2025
|
Yep, formatting had a bad day yesterday, but it recovered. Should run alright now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #48481
How
The url_base is configured as url_base: https://{{ config['domain'] }}.okta.com in the manifest.
Thus, making the 'domain' field mandatory will resolve this error.
User Impact
Breaking change to 1.0.0