Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Facebook Marketing: update API to v21.0 #50852

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

h0rban
Copy link
Contributor

@h0rban h0rban commented Jan 2, 2025

What

According to documentation, the Marketing API version currently used by the connector is being deprecated on 2025-02-04

Issues:

How

Updates the facebook-business package version to 21.0.5

Review guide

  1. airbyte-integrations/connectors/source-facebook-marketing/pyproject.toml
  2. airbyte-integrations/connectors/source-facebook-marketing/poetry.lock

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jan 2, 2025

@h0rban is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@h0rban h0rban temporarily deployed to community-ci-auto January 2, 2025 20:05 — with GitHub Actions Inactive
@h0rban h0rban changed the title ✨ Source Facebook Marketing: update Marketing API version from v19.0 to v21.0 ✨ Source Facebook Marketing: update API to v21.0 Jan 2, 2025
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 2, 2025
@h0rban h0rban temporarily deployed to community-ci-auto January 2, 2025 20:13 — with GitHub Actions Inactive
@h0rban h0rban temporarily deployed to community-ci-auto January 2, 2025 20:23 — with GitHub Actions Inactive
@h0rban h0rban marked this pull request as ready for review January 2, 2025 20:29
@marcosmarxm
Copy link
Member

Thanks for the contribution @h0rban I asked the connector team to take a look. They will probably read all the changelog and check if there any other updates are necessary to change the version. As the deprecation will only happen in February we have couple of weeks.

@marcosmarxm
Copy link
Member

There are some internal testing happening to accept the change. Depending it can impact in some breaking changes and the team will open a different pull request to get it merged @h0rban. One example was the migration from v17 to v19 where Facebook changed the token length.

@maxi297
Copy link
Contributor

maxi297 commented Jan 15, 2025

Hey @h0rban, thanks for your contribution! We have two concerns that prevents us from testing:

Let us know once it is updated and we will do the testing part for you. Thanks!

@h0rban
Copy link
Contributor Author

h0rban commented Jan 16, 2025

@maxi297 ^

@marcosmarxm
Copy link
Member

@maxi297 i triggered tests let's wait for the results

@marcosmarxm
Copy link
Member

@maxi297 regression tests failed (not sure how impact it has) and a spec test is also failing...

@maxi297
Copy link
Contributor

maxi297 commented Jan 20, 2025

Small update on this:

  • We have figured our the spec issue. It's because we rely on the lib to provide fields for custom insights reports. With the lib version update, the values have changed. That being said, it is only adding valid so this change is be backward compatible. We just need to add disable_for_version in the acceptance-test-config.yml
  • For regression testing, we will run a couple on our side to valide a few more things. We'll keep you posted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/facebook-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants