-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Facebook Marketing: update API to v21.0
#50852
base: master
Are you sure you want to change the base?
Conversation
@h0rban is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
v19.0
to v21.0
v21.0
Thanks for the contribution @h0rban I asked the connector team to take a look. They will probably read all the changelog and check if there any other updates are necessary to change the version. As the deprecation will only happen in February we have couple of weeks. |
There are some internal testing happening to accept the change. Depending it can impact in some breaking changes and the team will open a different pull request to get it merged @h0rban. One example was the migration from v17 to v19 where Facebook changed the token length. |
Hey @h0rban, thanks for your contribution! We have two concerns that prevents us from testing:
Let us know once it is updated and we will do the testing part for you. Thanks! |
@maxi297 ^ |
@maxi297 i triggered tests let's wait for the results |
@maxi297 regression tests failed (not sure how impact it has) and a spec test is also failing... |
Small update on this:
|
What
According to documentation, the Marketing API version currently used by the connector is being deprecated on 2025-02-04
Issues:
How
Updates the
facebook-business
package version to21.0.5
Review guide
airbyte-integrations/connectors/source-facebook-marketing/pyproject.toml
airbyte-integrations/connectors/source-facebook-marketing/poetry.lock
User Impact
Can this PR be safely reverted and rolled back?