Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use non-deprecated constructor for PostgreSQLContainer #522

Merged
merged 1 commit into from
Oct 26, 2020
Merged

use non-deprecated constructor for PostgreSQLContainer #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...o/airbyte/integrations/io/airbyte/integration_tests/sources/SingerPostgresSourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public class SingerPostgresSourceTest {

@BeforeEach
public void init() throws IOException {
psqlDb = new PostgreSQLContainer();
psqlDb = new PostgreSQLContainer("postgres:13-alpine");
psqlDb.start();

PostgreSQLContainerHelper.runSqlScript(MountableFile.forClasspathResource("init_ascii.sql"), psqlDb);
Expand Down Expand Up @@ -150,7 +150,7 @@ private void assertMessagesEquivalent(List<AirbyteRecordMessage> expectedMessage
public void testCanReadUtf8() throws IOException, InterruptedException, WorkerException {
// force the db server to start with sql_ascii encoding to verify the tap can read UTF8 even when
// default settings are in another encoding
PostgreSQLContainer db = (PostgreSQLContainer) new PostgreSQLContainer().withCommand("postgres -c client_encoding=sql_ascii");
PostgreSQLContainer db = (PostgreSQLContainer) new PostgreSQLContainer("postgres:13-alpine").withCommand("postgres -c client_encoding=sql_ascii");
db.start();
PostgreSQLContainerHelper.runSqlScript(MountableFile.forClasspathResource("init_utf8.sql"), db);

Expand Down
4 changes: 2 additions & 2 deletions airbyte-tests/src/acceptanceTests/java/io/airbyte/test/acceptance/AcceptanceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ public void init() {
connectionIds = Lists.newArrayList();
destinationImplIds = Lists.newArrayList();

sourcePsql = new PostgreSQLContainer();
targetPsql = new PostgreSQLContainer();
sourcePsql = new PostgreSQLContainer("postgres:13-alpine");
targetPsql = new PostgreSQLContainer("postgres:13-alpine");
sourcePsql.start();
targetPsql.start();

Expand Down