-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow scheduling getspec workers #523
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
32 changes: 14 additions & 18 deletions
32
airbyte-config/models/src/main/resources/types/StandardDiscoverSchemaInput.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,14 @@ | ||
{ | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"$id": "https://github.com/airbytehq/airbyte/blob/master/airbyte-config/models/src/main/resources/types/StandardDiscoverSchemaOutput.yaml", | ||
"title": "StandardDiscoverSchemaOutput", | ||
"description": "information required for connection.", | ||
"type": "object", | ||
"required": ["connectionConfiguration"], | ||
"additionalProperties": false, | ||
"properties": | ||
{ | ||
"connectionConfiguration": | ||
{ | ||
"description": "Integration specific blob. Must be a valid JSON string.", | ||
"type": "object", | ||
"existingJavaType": "com.fasterxml.jackson.databind.JsonNode", | ||
}, | ||
}, | ||
} | ||
--- | ||
"$schema": http://json-schema.org/draft-07/schema# | ||
"$id": https://github.com/airbytehq/airbyte/blob/master/airbyte-config/models/src/main/resources/types/StandardDiscoverSchemaOutput.yaml | ||
title: StandardDiscoverSchemaOutput | ||
description: information required for connection. | ||
type: object | ||
required: | ||
- connectionConfiguration | ||
additionalProperties: false | ||
properties: | ||
connectionConfiguration: | ||
description: Integration specific blob. Must be a valid JSON string. | ||
type: object | ||
existingJavaType: com.fasterxml.jackson.databind.JsonNode |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,11 +26,14 @@ | |
|
||
import io.airbyte.config.JobCheckConnectionConfig; | ||
import io.airbyte.config.JobDiscoverSchemaConfig; | ||
import io.airbyte.config.JobGetSpecConfig; | ||
import io.airbyte.config.JobOutput; | ||
import io.airbyte.config.JobSyncConfig; | ||
import io.airbyte.config.StandardCheckConnectionInput; | ||
import io.airbyte.config.StandardDiscoverSchemaInput; | ||
import io.airbyte.config.StandardSyncInput; | ||
import io.airbyte.workers.DefaultGetSpecWorker; | ||
import io.airbyte.workers.GetSpecWorker; | ||
import io.airbyte.workers.Worker; | ||
import io.airbyte.workers.process.ProcessBuilderFactory; | ||
import io.airbyte.workers.protocols.singer.DefaultSingerTap; | ||
|
@@ -40,6 +43,7 @@ | |
import io.airbyte.workers.protocols.singer.SingerSyncWorker; | ||
import io.airbyte.workers.wrappers.JobOutputCheckConnectionWorker; | ||
import io.airbyte.workers.wrappers.JobOutputDiscoverSchemaWorker; | ||
import io.airbyte.workers.wrappers.JobOutputGetSpecWorker; | ||
import io.airbyte.workers.wrappers.JobOutputSyncWorker; | ||
import java.nio.file.Path; | ||
import org.slf4j.Logger; | ||
|
@@ -78,22 +82,23 @@ public WorkerRun create(final Job job) { | |
LOGGER.info("job root: {}", jobRoot); | ||
|
||
switch (job.getConfig().getConfigType()) { | ||
case CHECK_CONNECTION_SOURCE: | ||
case CHECK_CONNECTION_DESTINATION: | ||
case CHECK_CONNECTION_SOURCE, CHECK_CONNECTION_DESTINATION -> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. using jdk14 switch |
||
final StandardCheckConnectionInput checkConnectionInput = getCheckConnectionInput(job.getConfig().getCheckConnection()); | ||
return creator.create( | ||
jobRoot, | ||
checkConnectionInput, | ||
new JobOutputCheckConnectionWorker( | ||
new SingerCheckConnectionWorker(new SingerDiscoverSchemaWorker(job.getConfig().getCheckConnection().getDockerImage(), pbf)))); | ||
case DISCOVER_SCHEMA: | ||
} | ||
case DISCOVER_SCHEMA -> { | ||
final StandardDiscoverSchemaInput discoverSchemaInput = getDiscoverSchemaInput(job.getConfig().getDiscoverSchema()); | ||
return creator.create( | ||
jobRoot, | ||
discoverSchemaInput, | ||
new JobOutputDiscoverSchemaWorker( | ||
new SingerDiscoverSchemaWorker(job.getConfig().getDiscoverSchema().getDockerImage(), pbf))); | ||
case SYNC: | ||
} | ||
case SYNC -> { | ||
final StandardSyncInput syncInput = getSyncInput(job.getConfig().getSync()); | ||
final SingerDiscoverSchemaWorker discoverSchemaWorker = new SingerDiscoverSchemaWorker(job.getConfig().getSync().getSourceDockerImage(), pbf); | ||
return creator.create( | ||
|
@@ -107,8 +112,16 @@ public WorkerRun create(final Job job) { | |
new SingerSyncWorker( | ||
new DefaultSingerTap(job.getConfig().getSync().getSourceDockerImage(), pbf, discoverSchemaWorker), | ||
new DefaultSingerTarget(job.getConfig().getSync().getDestinationDockerImage(), pbf)))); | ||
default: | ||
throw new RuntimeException("Unexpected config type: " + job.getConfig().getConfigType()); | ||
} | ||
case GET_SPEC -> { | ||
final JobGetSpecConfig getSpecInput = job.getConfig().getGetSpec(); | ||
final GetSpecWorker worker = new DefaultGetSpecWorker(pbf); | ||
return creator.create( | ||
jobRoot, | ||
getSpecInput, | ||
new JobOutputGetSpecWorker(worker)); | ||
} | ||
default -> throw new RuntimeException("Unexpected config type: " + job.getConfig().getConfigType()); | ||
} | ||
|
||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
airbyte-workers/src/main/java/io/airbyte/workers/wrappers/JobOutputGetSpecWorker.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
/* | ||
* MIT License | ||
* | ||
* Copyright (c) 2020 Airbyte | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in all | ||
* copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
* SOFTWARE. | ||
*/ | ||
|
||
package io.airbyte.workers.wrappers; | ||
|
||
import io.airbyte.config.JobGetSpecConfig; | ||
import io.airbyte.config.JobOutput; | ||
import io.airbyte.config.StandardGetSpecOutput; | ||
import io.airbyte.workers.GetSpecWorker; | ||
|
||
public class JobOutputGetSpecWorker extends OutputConvertingWorker<JobGetSpecConfig, StandardGetSpecOutput, JobOutput> { | ||
|
||
public JobOutputGetSpecWorker(GetSpecWorker innerWorker) { | ||
super( | ||
innerWorker, | ||
standardGetSpecOutput -> new JobOutput().withOutputType(JobOutput.OutputType.GET_SPEC).withGetSpec(standardGetSpecOutput)); | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated to the PR but noticed that this was json not yaml so i fixed it