Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Shopify: Adds Inventory Items #7973

Closed
wants to merge 10 commits into from

Conversation

jonoirwinrsa
Copy link
Contributor

@jonoirwinrsa jonoirwinrsa commented Nov 15, 2021

What

Adds the Inventory Item table to the Shopify Connector.

Problem this solves

The Inventory Item table is required to get the cost price of inventory items. This is useful for calculating cost of sales, profit and similar metrics.

Addresses Airbyte issue: #7527

Shopify API Inventory Items docs

How

Makes another request to the Shopify API and saves the result to a new table.

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 15, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 15, 2021
@jonoirwinrsa jonoirwinrsa changed the title Add Inventory Items to Shopify Connector Source Shopify: Adds Inventory Items Nov 15, 2021
@jonoirwinrsa jonoirwinrsa marked this pull request as draft November 15, 2021 13:09
@harshithmullapudi
Copy link
Contributor

@jonoirwinrsa thanks for the contribution. We will review this soon

@sherifnada
Copy link
Contributor

@jonoirwinrsa @bazarnov can take a look -- we're a bit backed up with community contributions but we'll respond soon!

Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, small corrections and we're good to go.

Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshithmullapudi
Copy link
Contributor

Hey @jonoirwinrsa can you update the version in setup.py also ? Otherwise this looks good.

@jonoirwinrsa
Copy link
Contributor Author

Hey @jonoirwinrsa can you update the version in setup.py also ? Otherwise this looks good.

Hi @harshithmullapudi I couldn't find a version number in setup.py but I did find relevant ones in a few other places which I have updated.

@sherifnada
Copy link
Contributor

actually it's not necessary to do it for setup.py only for dockerfile, @harshithmullapudi if the checklist is completed we're ready to go

@alafanechere alafanechere self-assigned this Nov 23, 2021
@jonoirwinrsa jonoirwinrsa changed the title Source Shopify: Adds Inventory Items 🎉 Source Shopify: Adds Inventory Items Nov 24, 2021
@jonoirwinrsa
Copy link
Contributor Author

@bazarnov is there anything more that needs to be done here? I think everything has been addressed

@bazarnov
Copy link
Collaborator

@bazarnov is there anything more that needs to be done here? I think everything has been addressed

I believe we are good to go.
@marcosmarxm

@marcosmarxm
Copy link
Member

Thanks @jonoirwinrsa I merge the contribution on #8320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants