-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Shopify: Adds Inventory Items #7973
Conversation
fix: parse response as json object not array
@jonoirwinrsa thanks for the contribution. We will review this soon |
@jonoirwinrsa @bazarnov can take a look -- we're a bit backed up with community contributions but we'll respond soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, small corrections and we're good to go.
airbyte-integrations/connectors/source-shopify/source_shopify/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-shopify/source_shopify/schemas/inventory_items.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @jonoirwinrsa can you update the version in setup.py also ? Otherwise this looks good. |
Hi @harshithmullapudi I couldn't find a version number in |
actually it's not necessary to do it for |
@bazarnov is there anything more that needs to be done here? I think everything has been addressed |
I believe we are good to go. |
Thanks @jonoirwinrsa I merge the contribution on #8320 |
What
Adds the Inventory Item table to the Shopify Connector.
Problem this solves
The Inventory Item table is required to get the cost price of inventory items. This is useful for calculating cost of sales, profit and similar metrics.
Addresses Airbyte issue: #7527
Shopify API Inventory Items docs
How
Makes another request to the Shopify API and saves the result to a new table.
Pre-merge Checklist
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here