-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source LinkedIn Ads: hands 429 response status code #8382
Conversation
/test connector=connectors/source-linkedin-ads
|
airbyte-integrations/connectors/source-linkedin-ads/source_linkedin_ads/source.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@annalvova05 , Please publish this changes |
/test connector=connectors/source-linkedin-ads
|
/publish connector=connectors/source-linkedin-ads
|
* Add log message for 429 status_code * fix * bump version * bump version and format
What
We catch 429 error during sync.
How
Add log message, which describes why we stop sync. Also update doc.
Recommended reading order
source.py
linkedin-ads.md
🚨 User Impact 🚨
Are there any breaking changes? If yes, please make sure to include it here and in any changelogs with the 🚨🚨 emoji
What is the end result perceived by the user?
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here