Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source LinkedIn Ads: hands 429 response status code #8382

Merged
merged 5 commits into from
Dec 2, 2021

Conversation

annalvova05
Copy link
Contributor

What

We catch 429 error during sync.

How

Add log message, which describes why we stop sync. Also update doc.

Recommended reading order

  1. source.py
  2. linkedin-ads.md

🚨 User Impact 🚨

Are there any breaking changes? If yes, please make sure to include it here and in any changelogs with the 🚨🚨 emoji
What is the end result perceived by the user?

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@annalvova05 annalvova05 self-assigned this Dec 1, 2021
@annalvova05 annalvova05 linked an issue Dec 1, 2021 that may be closed by this pull request
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 1, 2021
@annalvova05
Copy link
Contributor Author

annalvova05 commented Dec 1, 2021

/test connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1526160260
✅ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1526160260
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                               Stmts   Miss  Cover
	 ------------------------------------------------------
	 source_linkedin_ads/__init__.py        2      0   100%
	 source_linkedin_ads/analytics.py      45      1    98%
	 source_linkedin_ads/source.py        168     77    54%
	 source_linkedin_ads/utils.py          83      5    94%
	 ------------------------------------------------------
	 TOTAL                                298     83    72%

@jrhizor jrhizor temporarily deployed to more-secrets December 1, 2021 14:13 Inactive
@annalvova05 annalvova05 requested a review from grubberr December 1, 2021 14:21
@annalvova05 annalvova05 temporarily deployed to more-secrets December 1, 2021 14:22 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antixar
Copy link
Contributor

antixar commented Dec 2, 2021

@annalvova05 , Please publish this changes

@annalvova05
Copy link
Contributor Author

annalvova05 commented Dec 2, 2021

/test connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1530312680
✅ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1530312680
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  945    441    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                               Stmts   Miss  Cover
	 ------------------------------------------------------
	 source_linkedin_ads/__init__.py        2      0   100%
	 source_linkedin_ads/analytics.py      45      1    98%
	 source_linkedin_ads/source.py        168     77    54%
	 source_linkedin_ads/utils.py          83      5    94%
	 ------------------------------------------------------
	 TOTAL                                298     83    72%

@annalvova05 annalvova05 temporarily deployed to more-secrets December 2, 2021 11:19 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 2, 2021 11:20 Inactive
@annalvova05
Copy link
Contributor Author

annalvova05 commented Dec 2, 2021

/publish connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1530349633
✅ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1530349633

@jrhizor jrhizor temporarily deployed to more-secrets December 2, 2021 11:30 Inactive
@annalvova05 annalvova05 merged commit 9f685b9 into master Dec 2, 2021
@annalvova05 annalvova05 deleted the alvova/7206-fix-linkedin-rate-limits branch December 2, 2021 12:17
@annalvova05 annalvova05 temporarily deployed to more-secrets December 2, 2021 12:18 Inactive
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* Add log message for 429 status_code

* fix

* bump version

* bump version and format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinkedIn Ads Source hangs after preparing tmp Tables
5 participants