Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Destination GCS: add new region #8386

Merged
merged 5 commits into from
Dec 3, 2021
Merged

Conversation

agrass
Copy link
Contributor

@agrass agrass commented Dec 1, 2021

What

missing region southamerica-west1 to Google Cloud Storage destination

How

Add option on spec

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Dec 1, 2021
@alafanechere alafanechere changed the title add new region Destination Google Cloud Storage: add new region Dec 1, 2021
@alafanechere alafanechere added the type/enhancement New feature or request label Dec 1, 2021
@alafanechere alafanechere self-assigned this Dec 1, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 2, 2021
@alafanechere
Copy link
Contributor

Hi @agrass thanks for this addition. I allowed myself to add another missing region + required version bumping. Unfortunately the acceptance test are not passing on my side branch. I'll try to fix this.

@jrhizor jrhizor temporarily deployed to more-secrets December 2, 2021 19:03 Inactive
@tuliren tuliren changed the title Destination Google Cloud Storage: add new region 🎉 Destination GCS: add new region Dec 3, 2021
@tuliren
Copy link
Contributor

tuliren commented Dec 3, 2021

I will merge this one first, and merge @alafanechere's follow up PR afterwards.

@tuliren tuliren merged commit 2c34c70 into airbytehq:master Dec 3, 2021
@tuliren tuliren mentioned this pull request Dec 3, 2021
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* add new region

* update seed files for destination-gcs

* add region northamerica-northeast2

* update changelog

Co-authored-by: alafanechere <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/gcs connectors/destinations-files type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants