Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fields in source-connectors specifications: google-search-console #9186

Merged
merged 7 commits into from
Jan 5, 2022

Conversation

ycherniaiev
Copy link
Contributor

@ycherniaiev ycherniaiev commented Dec 29, 2021

What

Add title and description properties to each field in source-connectors specifications:
source-google-search-console

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@ycherniaiev ycherniaiev self-assigned this Dec 29, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Dec 29, 2021
@ycherniaiev ycherniaiev temporarily deployed to more-secrets December 29, 2021 12:36 Inactive
@ycherniaiev ycherniaiev requested a review from grubberr December 29, 2021 12:37
@ycherniaiev ycherniaiev added the area/documentation Improvements or additions to documentation label Dec 29, 2021
@ycherniaiev
Copy link
Contributor Author

ycherniaiev commented Dec 29, 2021

/test connector=connectors/source-google-search-console

🕑 connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1634039919
✅ connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1634039919
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                            Stmts   Miss  Cover
	 -----------------------------------------------------------------------------------
	 source_google_search_console/__init__.py                            2      0   100%
	 source_google_search_console/service_account_authenticator.py      14      6    57%
	 source_google_search_console/source.py                             37     22    41%
	 source_google_search_console/streams.py                           107     31    71%
	 -----------------------------------------------------------------------------------
	 TOTAL                                                             160     59    63%

@ycherniaiev ycherniaiev temporarily deployed to more-secrets December 29, 2021 12:46 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 29, 2021 12:47 Inactive
@ycherniaiev
Copy link
Contributor Author

ycherniaiev commented Dec 31, 2021

/test connector=connectors/destination-google-search-console

🕑 connectors/destination-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1640471077
❌ connectors/destination-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1640471077
🐛

@jrhizor jrhizor temporarily deployed to more-secrets December 31, 2021 10:30 Inactive
@ycherniaiev
Copy link
Contributor Author

ycherniaiev commented Dec 31, 2021

/test connector=connectors/source-google-search-console

🕑 connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1640751954
✅ connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1640751954
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                            Stmts   Miss  Cover
	 -----------------------------------------------------------------------------------
	 source_google_search_console/__init__.py                            2      0   100%
	 source_google_search_console/service_account_authenticator.py      14      6    57%
	 source_google_search_console/source.py                             37     22    41%
	 source_google_search_console/streams.py                           107     31    71%
	 -----------------------------------------------------------------------------------
	 TOTAL                                                             160     59    63%

@jrhizor jrhizor temporarily deployed to more-secrets December 31, 2021 12:40 Inactive
@grubberr grubberr requested a review from igrankova January 5, 2022 15:07
Signed-off-by: Sergey Chvalyuk <[email protected]>
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr temporarily deployed to more-secrets January 5, 2022 15:31 Inactive
@grubberr
Copy link
Contributor

grubberr commented Jan 5, 2022

/test connector=connectors/source-google-search-console

🕑 connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1659073443
✅ connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1659073443
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                            Stmts   Miss  Cover
	 -----------------------------------------------------------------------------------
	 source_google_search_console/__init__.py                            2      0   100%
	 source_google_search_console/service_account_authenticator.py      14      6    57%
	 source_google_search_console/source.py                             37     22    41%
	 source_google_search_console/streams.py                           119     28    76%
	 -----------------------------------------------------------------------------------
	 TOTAL                                                             172     56    67%

@jrhizor jrhizor temporarily deployed to more-secrets January 5, 2022 15:35 Inactive
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr temporarily deployed to more-secrets January 5, 2022 15:44 Inactive
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr temporarily deployed to more-secrets January 5, 2022 15:49 Inactive
@grubberr grubberr merged commit 0161dd6 into master Jan 5, 2022
@grubberr grubberr deleted the ycherniaiev/issue-8928-update-title-description branch January 5, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update fields in source-connectors specifications: google-search-console
4 participants