Update fields in source-connectors specifications: google-sheets #9208

ycherniaiev · 2021-12-30T11:35:04Z

What

Add title and description properties to each field in source-connectors specifications:
google-sheets

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

This change is

ycherniaiev · 2021-12-30T11:39:53Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1637338377
❌ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1637338377
🐛 https://gradle.com/s/3ptunuufhsy2a
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs1] - docker.errors.Cont...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestSpec::test_match_expected[inputs0] - json.decoder.JSO...
ERROR test_core.py::TestSpec::test_defined_refs_exist_in_json_spec_file[inputs0]
ERROR test_core.py::TestSpec::test_oauth_flow_parameters[inputs0] - docker.er...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============== 3 failed, 5 passed, 1 skipped, 7 errors in 11.37s ===============

ycherniaiev · 2021-12-31T10:27:20Z

/test connector=connectors/destination-google-sheets

🕑 connectors/destination-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1640468204
❌ connectors/destination-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1640468204
🐛

grubberr · 2022-01-19T10:45:46Z

/test connector=connectors/source-google-sheets

grubberr · 2022-01-20T09:13:51Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1722553722
❌ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1722553722
🐛 https://gradle.com/s/x2ve52k3q3b5y
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs1] - docker.errors.Cont...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestSpec::test_match_expected[inputs0] - json.decoder.JSO...
ERROR test_core.py::TestSpec::test_defined_refs_exist_in_json_spec_file[inputs0]
ERROR test_core.py::TestSpec::test_oauth_flow_parameters[inputs0] - docker.er...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============== 3 failed, 5 passed, 1 skipped, 7 errors in 11.26s ===============

…ption Signed-off-by: Sergey Chvalyuk <[email protected]>

codecov · 2022-01-25T09:14:41Z

Codecov Report

❗ No coverage uploaded for pull request base (master@0dfbfdc). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 35a357f differs from pull request most recent head 8c64bae. Consider uploading reports for the commit 8c64bae to get more accurate results

@@            Coverage Diff            @@
##             master    #9208   +/-   ##
=========================================
  Coverage          ?   61.53%           
=========================================
  Files             ?        7           
  Lines             ?      299           
  Branches          ?        0           
=========================================
  Hits              ?      184           
  Misses            ?      115           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dfbfdc...8c64bae. Read the comment docs.

grubberr · 2022-01-25T09:18:37Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1744579170
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1744579170
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                Stmts   Miss  Cover
	 -----------------------------------------------------------------------
	 google_sheets_source/__init__.py                        2      0   100%
	 google_sheets_source/client.py                         22      5    77%
	 google_sheets_source/google_sheets_source.py          103     84    18%
	 google_sheets_source/helpers.py                       129     26    80%
	 google_sheets_source/models/__init__.py                 2      0   100%
	 google_sheets_source/models/spreadsheet.py             34      0   100%
	 google_sheets_source/models/spreadsheet_values.py      12      0   100%
	 -----------------------------------------------------------------------
	 TOTAL                                                 304    115    62%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 15 passed, 1 skipped in 41.50s ========================

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr · 2022-01-25T10:00:27Z

/publish connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1744756912
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1744756912

Signed-off-by: Sergey Chvalyuk <[email protected]>

Upd

3a3c982

ycherniaiev added area/documentation Improvements or additions to documentation area/connectors Connector related issues labels Dec 30, 2021

ycherniaiev requested a review from grubberr December 30, 2021 11:35

ycherniaiev self-assigned this Dec 30, 2021

github-actions bot removed the area/documentation Improvements or additions to documentation label Dec 30, 2021

Update google-sheets.md

b8d055c

github-actions bot added the area/documentation Improvements or additions to documentation label Dec 30, 2021

ycherniaiev temporarily deployed to more-secrets December 30, 2021 11:39 Inactive

jrhizor temporarily deployed to more-secrets December 30, 2021 11:41 Inactive

jrhizor temporarily deployed to more-secrets December 31, 2021 10:29 Inactive

igrankova assigned grubberr Jan 5, 2022

octavia-squidington-iii temporarily deployed to more-secrets January 19, 2022 10:47 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 20, 2022 09:16 Inactive

Merge branch 'master' into ycherniaiev/issue-8929-update-title-descri…

d254cc7

…ption Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr temporarily deployed to more-secrets January 25, 2022 09:13 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 25, 2022 09:21 Inactive

grubberr added 2 commits January 25, 2022 11:58

fixes

e79f9f2

Signed-off-by: Sergey Chvalyuk <[email protected]>

fixes

35a357f

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr approved these changes Jan 25, 2022

View reviewed changes

grubberr temporarily deployed to more-secrets January 25, 2022 10:00 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 25, 2022 10:02 Inactive

source_specs.yaml updated

8c64bae

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr temporarily deployed to more-secrets January 25, 2022 10:22 Inactive

grubberr merged commit 7806dbc into master Jan 25, 2022

grubberr deleted the ycherniaiev/issue-8929-update-title-description branch January 25, 2022 10:22

This was referenced Jan 25, 2022

Bump Airbyte version from 0.35.9-alpha to 0.35.10-alpha #9798

Closed

Bump Airbyte version from 0.35.9-alpha to 0.35.10-alpha #9800

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update fields in source-connectors specifications: google-sheets #9208

Update fields in source-connectors specifications: google-sheets #9208

ycherniaiev commented Dec 30, 2021 •

edited by grubberr

Loading

ycherniaiev commented Dec 30, 2021 •

edited by github-actions bot

Loading

ycherniaiev commented Dec 31, 2021 •

edited by github-actions bot

Loading

grubberr commented Jan 19, 2022

grubberr commented Jan 20, 2022 •

edited by github-actions bot

Loading

codecov bot commented Jan 25, 2022 •

edited

Loading

grubberr commented Jan 25, 2022 •

edited by github-actions bot

Loading

grubberr commented Jan 25, 2022 •

edited by github-actions bot

Loading

Update fields in source-connectors specifications: google-sheets #9208

Update fields in source-connectors specifications: google-sheets #9208

Conversation

ycherniaiev commented Dec 30, 2021 • edited by grubberr Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

ycherniaiev commented Dec 30, 2021 • edited by github-actions bot Loading

ycherniaiev commented Dec 31, 2021 • edited by github-actions bot Loading

grubberr commented Jan 19, 2022

grubberr commented Jan 20, 2022 • edited by github-actions bot Loading

codecov bot commented Jan 25, 2022 • edited Loading

Codecov Report

grubberr commented Jan 25, 2022 • edited by github-actions bot Loading

grubberr commented Jan 25, 2022 • edited by github-actions bot Loading

ycherniaiev commented Dec 30, 2021 •

edited by grubberr

Loading

ycherniaiev commented Dec 30, 2021 •

edited by github-actions bot

Loading

ycherniaiev commented Dec 31, 2021 •

edited by github-actions bot

Loading

grubberr commented Jan 20, 2022 •

edited by github-actions bot

Loading

codecov bot commented Jan 25, 2022 •

edited

Loading

grubberr commented Jan 25, 2022 •

edited by github-actions bot

Loading

grubberr commented Jan 25, 2022 •

edited by github-actions bot

Loading