-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐙 octavia-cli: list connectors #9546
Conversation
@alafanechere these new commands are listing the current version of the containers in the user instance OR the latest version in Docker hub? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some initial comments! It's amazing :D
] | ||
return definitions | ||
|
||
# TODO alafanechere: declare in a specific formatting module because it will probably be reused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a base class to control the CLI specification where users can configure too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right. I did not want to make premature optimizations and think that this refactoring need and the right place to put these functions will become more evident during the implementation of other commands.
I opened the next PR (draft) that implements a lot of the |
We are using this endpoint with I think merges GitHub's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Though it looks like there are some build errors that should be fixed before merging
Thank you @marcosmarxm and @lmossman for the review and your valuable feedback! |
What
We want to display a list of existing sources and destinations connectors that can then be created with (yet to be implemented)
octavia create
commands.How
octavia
>list
>connectors
sources
anddestinations
commands in theconnectors
group to list existing sources and destinations in an Airbyte instance. Make use of aDefinitions
abstract class tooctavia list connectors sources
+octavia list connectors destinations
Recommended reading order
octavia-cli/octavia_cli/entrypoint.py
> Addition oflist
subcommand tooctavia
command groupoctavia-cli/octavia_cli/list/commands.py
> Declaration of thelist
andconnectors
command groups +sources
anddestinations
commandsoctavia-cli/octavia_cli/list/definitions.py
Implementation of aDefinitions
abstract class to retrieve and display sources and destinations lists.octavia-cli/unit_tests/test_list/*
write unit tests for the new code.octavia-cli/unit_tests/test_entrypoint.py
update entrypoint test.🚨 User Impact 🚨
octavia --airbyte-url="https://demo.airbyte.io" list connectors sources
andoctavia --airbyte-url="https://demo.airbyte.io" list connectors destination
are now available commands and display the following output.