Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): Get minio secrets from Values #9769

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

reggermont
Copy link
Contributor

What

Applying the helm chart is failing with the following error:

STDERR: Error: template: airbyte/templates/env-configmap.yaml:41:37: 
executing "airbyte/templates/env-configmap.yaml" at <include "airbyte.minio.accessKey.password" .>:
error calling include: template: no template "airbyte.minio.accessKey.password" associated with 
template "gotpl"

It happens because the method doesn't exist in the _helpers.tpl. But the value exists in the Values.yaml

How

Just replace calls to methods to values instead, and enjoy the full power of helm!

🚨 User Impact 🚨

None. Applying the fix will at the contrary improve helmers' life

Pre-merge Checklist

No checklist fits the MR

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2022

CLA assistant check
All committers have signed the CLA.

@marcosmarxm
Copy link
Member

thanks @reggermont can you sign the CLA?

@reggermont
Copy link
Contributor Author

reggermont commented Jan 25, 2022

I have the following issue to sign the CLA:

  • According to my company's rules, I must change the committer's email address to [email protected]
  • The CLAassistant doesn't want me to sign the CLA because the email address is not linked to a GitHub account

Will try to find a way to get an account with this email address

@ALEIA-OpenSource
Copy link
Contributor

I have the following issue to sign the CLA:

  • According to my company's rules, I must change the committer's email address to [email protected]
  • The CLAassistant doesn't want me to sign the CLA because the email address is not linked to a GitHub account

Will try to find a way to get an account with this email address

Hello. As @reggermont asked for me to sign the CLA, i did. That way, he is still the committer and ALEIA approves his commit made in our name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform community kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants