Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a public setOrderOptedIn function #26

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

creative-dev-lab
Copy link
Contributor

Issue Report scenario is:

  1. Customer buys a shirt and turns on AR. The OCP displays the AR widget, this is correct.
  2. The next time they buy a notebook (the widget is still on for other eligible products eg shirts). The OCP displays the AR widget, which is not correct since it’s a notebook.

So my thought on this report is there isn't an actual issue in our SDK.
But The problem is that they decide to render the multi-opt-in widget after they got the eligibility result of the multi-opt-in widget by calling an exposed function named checkMultiOptInEligibility . and if it returns not-eligible, then they rather not render multi-opt-in widget on their end.
which means our SDK skips the operation of updating OrderOptedIn value.
So if OrderOptedIn was previously set as true , this value won't change in the above case, and on confirmation view, the widget will be automatically eligible.
This made the issue.

So I added another function called setOrderOptedIn to let them set the value manually on their end just for them.

@creative-dev-lab creative-dev-lab merged commit 93c592c into master Jun 16, 2022
@creative-dev-lab creative-dev-lab deleted the eli/addedSetOrderOptedInFunction branch June 16, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants