update company name from backend, remove hardcoded company name #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plans
How it works
We are currently getting company name, privacy url, find out more url, category mapping data etc. from
connector/graphql
with below query.if
privacyUrl
isnull
, we hide "By opting in..." text block.if not, we use this
privacyUrl
for the privacy link in "By opting in..." text block.Also we use
name
value for the company name in "By opting in..." text block.And we use
popupFindOutMoreUrl
for the find out more URL in Learn More popup widget.-- Note
name
andpopupFindOutMoreUrl
are not nullable whileprivacyUrl
is nullable.And in order to test it successfully,
categoryMappings
should have data. but optional.Test Environment
../airrobedemo/ApplicationController.kt -> ApplicationController class -> onCreate()
, we haveinitialize
function which hasappId
andmode
as params.appId
andmode
and test out the below cases.Test Cases
We can test this out by simulating the connector api call with a specific
app_id
.null
.app_id
.app_id
.