Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 関数同士の比較の実装 #537

Merged
merged 4 commits into from
Mar 31, 2024
Merged

feat: 関数同士の比較の実装 #537

merged 4 commits into from
Mar 31, 2024

Conversation

ikasoba
Copy link
Collaborator

@ikasoba ikasoba commented Jan 20, 2024

What

  • 関数同士の比較をできるようにしました
    • ホスト側の関数をラップした関数の比較はその関数への参照を比較します
    • aiscript内で生成された関数については関数オブジェクトの参照を比較します

Why

Additional info (optional)

@ikasoba
Copy link
Collaborator Author

ikasoba commented Jan 20, 2024

失敗に失敗を重ねてPRを作成しました m(_ _)m

FineArchs
FineArchs reviewed Jan 20, 2024
View reviewed changes
test/index.ts Outdated Show resolved Hide resolved
src/interpreter/util.ts Show resolved Hide resolved
@salano-ym
Copy link
Member

二人に承認されて1日以上経ったのでマージします。

@salano-ym salano-ym merged commit 4e4a37e into aiscript-dev:aiscript-next Mar 31, 2024
4 checks passed
@FineArchs FineArchs mentioned this pull request Jul 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FineArchs FineArchs FineArchs approved these changes

@salano-ym salano-ym salano-ym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikasoba @salano-ym @FineArchs