-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ラベル構文の追加 #885
Open
takejohn
wants to merge
19
commits into
aiscript-dev:master
Choose a base branch
from
takejohn:feat/loop-label_2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: ラベル構文の追加 #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
FineArchs
reviewed
Dec 31, 2024
FineArchs
reviewed
Dec 31, 2024
Co-authored-by: FineArchs <[email protected]>
FineArchs
approved these changes
Dec 31, 2024
uzmoi
reviewed
Jan 4, 2025
uzmoi
approved these changes
Jan 9, 2025
FineArchs
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#859 から一部コミットをcherry-pickしてPRを新規作成しました。
#840 (comment) に基づいて、ラベル構文を追加します。
Why
Additional info (optional)
これまでに出た問題の解決策:
break #l
の後は、文の終わりでない場合にbreak文に指定された式としてパースされる。EOF, 改行,while
,elif
,else
,,
,;
,}
を文の終わりとしている。#l: do break #l while false
が文としてパースされるため、「Multiple statements cannot be placed on a single line.」の文法エラーとなる。