Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

popup step - Chrome DevTools Protocol - targetId deprecated in some methods #64

Closed
kensoh opened this issue Oct 29, 2017 · 1 comment
Closed

popup step - Chrome DevTools Protocol - targetId deprecated in some methods #64

kensoh opened this issue Oct 29, 2017 · 1 comment
Labels
feature

Comments

@kensoh
Copy link
Member

kensoh commented Oct 29, 2017

Under Target domain,

  • Target.attachToTarget now returns a sessionId instead of success
  • Target.detachFromTarget requires sessionId instead of targetId
  • Target.sendMessageToTarget requires sessionId instead of targetId

These deprecation / changes in Chrome DevTools Protocol will make popup step not work.

Making a commit with codebase update to work with this newer version. Tested on Chrome - version 61.0.3163.100 (Official Build) (64-bit) by verifying expected behavior and validating tagui_chrome.log. Raising this issue for easy reference in future.
@kensoh kensoh added the feature label Oct 29, 2017
kensoh added a commit that referenced this issue Oct 29, 2017
@kensoh
#64 - update popup step for CDP changes
25d48fc 
Chrome DevTools Protocol, under Target domain
(https://chromedevtools.github.io/devtools-protocol/tot/Target/),

- Target.attachToTarget now returns a sessionId instead of success
- Target.detachFromTarget requires sessionId instead of targetId
- Target.sendMessageToTarget requires sessionId instead of targetId

These deprecation / changes in Chrome DevTools Protocol will make popup
step not work.

Making a commit with codebase update to work with this newer version.
Tested on Chrome - version 61.0.3163.100 (Official Build) (64-bit) by
verifying expected behavior and validating tagui_chrome.log.

Raising issue #64 for easy reference in future.
@kensoh
Copy link
Member Author

kensoh commented Oct 29, 2017

Committed update to master, closing issue.

@kensoh kensoh closed this as completed Oct 29, 2017
@kensoh kensoh changed the title Chrome DevTools Protocol - targetId deprecated in some methods popup step - Chrome DevTools Protocol - targetId deprecated in some methods Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kensoh