Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#756 - detect sikulix requirement in helper functions #774

Merged
merged 1 commit into from
Apr 2, 2020
Merged

#756 - detect sikulix requirement in helper functions #774

merged 1 commit into from
Apr 2, 2020

Conversation

kensoh
Copy link
Member

@kensoh kensoh commented Apr 1, 2020

No description provided.

@kensoh
Copy link
Member Author

kensoh commented Apr 1, 2020

Hi @siowyisheng this fixes #756, for your review and testing before merge.

@kensoh kensoh requested a review from siowyisheng April 1, 2020 09:18
@kensoh kensoh mentioned this pull request Apr 1, 2020
Closed
@siowyisheng
Copy link
Contributor

LGTM!

@siowyisheng siowyisheng merged commit 2b0380f into master Apr 2, 2020
@kensoh kensoh deleted the detect_sikulix_in_helper_functions branch April 2, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siowyisheng siowyisheng Awaiting requested review from siowyisheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kensoh @siowyisheng