Fix tests checking recount on immortal objects #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Python 3.12 singleton objects like `None` are considered to be immortal. Their reference count is always set to a high value (currently -1U). In effect, some of the unit tests which verify ref counting of the None object attempted to execute loops with ~43B iterations. The test cases have been rewritten to validate the reference count with a constant number of iterations. The new implementation requires that `gc.collect` releases all reachable references. This appears to be the case in all tested CPython versions. Closes #18.
ajakubek
force-pushed
the
test_loop_fixes
branch
from
5d689a6 to
34466ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Python 3.12 singleton objects like
Noneare considered to be immortal. Their reference count is always set to a high value (currently -1U).In effect, some of the loops in unit tests which verified refcounts of the None object attempted to run for ~4.3B iterations.
The test caes have been rewritten to validate reference counts with a constant number of iterations.