Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto select based on current line and test #27

Merged
merged 1 commit into from
Feb 14, 2016

Conversation

HParker
Copy link
Contributor

@HParker HParker commented Dec 10, 2015

part of #12

I did two things here:

  • the post condition line is now assumed to be the current line rather than having to select it (it has unexpected behavior when selecting multiple lines)
  • also, (I hope this isn't just me) the conditions where being pulled out reversed
puts "some are greater than 3" unless long_method.empty?

previously became:

unless puts "some are greater than 3"
  long_method.empty?
end

now becomes:

unless long_method.empty?
  puts "some are greater than 3"
end

Let me know what you think.
Thanks!

@mikenichols
Copy link
Contributor

Awesome work, thanks man. When I was testing this, I got the reversed conditions once, but foolishly shrugged it off. Also 👍 for adding a test.

@HParker
Copy link
Contributor Author

HParker commented Dec 24, 2015

anytime. Anything else you would like to see here?

@mikenichols
Copy link
Contributor

That's up to @ajvargo. He's been good at responding relatively quickly.

@HParker
Copy link
Contributor Author

HParker commented Dec 25, 2015

Cool. No hurry, just curious. :)

ajvargo pushed a commit that referenced this pull request Feb 14, 2016
auto select based on current line and test
@ajvargo ajvargo merged commit e6b7125 into ajvargo:master Feb 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants