cache: add TTL support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
commented
Nov 22, 2021
pkg/cache/groupcache.go
Outdated
| config, err := parseGroupcacheConfig(conf) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return NewGroupcacheWithConfig(logger, reg, config, basepath, r, bucket) | ||
| return NewGroupcacheWithConfig(logger, reg, config, basepath, r, bucket, isTSDBChunkFile, isMetaFile, isBlocksRootDir, MetaFileExistsTTL, MetafileDoesntExistTTL, MetafileContentTTL, ChunkObjectAttrsTTL, ChunkSubrangeTTL, BlocksIterTTL) |
There was a problem hiding this comment.
It would be cool if our struct had an interface like this to avoid passing so many parameters:
https://github.com/thanos-io/thanos/blob/main/pkg/store/cache/caching_bucket_factory.go#L109-L114
akanshat
approved these changes
Nov 22, 2021
pkg/cache/groupcache.go
Outdated
| if isBlocksRootDir(parsedData.Name) { | ||
| return dest.UnmarshalBinary(encodedList, time.Now().Add(BlocksIterTTL)) | ||
| } | ||
| panic("caching bucket layer must not call on unconfigured paths") |
There was a problem hiding this comment.
I was under the impression we should never use panic. Shouldn't we be returning an error instead of panicking?
There was a problem hiding this comment.
I think that using panics to check for logic bugs in code is one of the very few valid use cases for it 😄
|
@GiedriusS Can you please rebase and resolve the conflict? |
Adds TTL support to galaxycache as per this pull request: thanos-community/galaxycache#1 Signed-off-by: Giedrius Statkevičius <[email protected]>
|
@akanshat rebased 👼 hopefully we can work on improving the interface now! Then we could merge this ❤️ |
Signed-off-by: akanshat <[email protected]>
Signed-off-by: akanshat <[email protected]>
Signed-off-by: akanshat <[email protected]>
Signed-off-by: akanshat <[email protected]>
Signed-off-by: akanshat <[email protected]>
Signed-off-by: akanshat <[email protected]>
move cache TTLs to a struct
|
Let's merge this now as well? @akanshat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds TTL support to galaxycache as per this pull request:
thanos-community/galaxycache#1
Signed-off-by: Giedrius Statkevičius [email protected]
With these changes: