Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow credit card users to add funds at deploy time #628

Open
anilmurty opened this issue Jan 11, 2025 · 8 comments
Open

Allow credit card users to add funds at deploy time #628

anilmurty opened this issue Jan 11, 2025 · 8 comments

Comments

@anilmurty
Copy link

Problem Statement

Deployments created by credit card users default to $5 in the escrow, which (depending on resources leased) can sometimes allow the deployment to run for only a few minutes. Users have the option to "Add Funds" but sometimes forget to do so and have their lease closed.

Proposed Solution

Allow credit card users to optionally add/ increase the funds that go into escrow at deploy time.

The changes would be

  1. Show a text box (similar to the one we show for wallet users) where a default value of $5 is populated and the user has the option of increasing it. This would be added under the resources box shown below
    Screenshot 2025-01-10 at 4 46 34 PM

  2. Check credit balance to ensure there are funds to fund the escrow account.

  3. Give user the option to purchase more funds

One thing I realized @aktdenis @baktun14 @ygrishajev is that we call both "Adding funds to the account" and "adding funds to the deployment" as "Add Funds" - we may need some distinction between the two

@aktdenis
Copy link

@anilmurty
how about "Top Up Deployment"?... or the other way around and say "Top Up Account"?

@anilmurty anilmurty moved this from Backlog (not prioritized) to Up Next (prioritized) in Client Product and Engineering Roadmap Jan 24, 2025
@baktun14 baktun14 assigned baktun14 and unassigned stalniy Jan 27, 2025
@anilmurty
Copy link
Author

hey @aktdenis - those work but I think they may be a tad long. After thinking over this a bit, I'm thinking we leave this one as Add "Funds" and change the credit purchase one to "Buy Credits" - wdyt? - this way both are just 2 words

Image

@aktdenis
Copy link

aktdenis commented Feb 4, 2025

hey @anilmurty, good point. it's distinguishable and works for me

@jzsfkzm
Copy link
Contributor

jzsfkzm commented Feb 6, 2025

Hi there, I created a PR for this. I thought it would make sense to unify ManagedDeploymentConfirm and DeploymentDepositModal. In this change we'd be rendering the list of services on DeploymentDepositModal and use that modal for managed wallets. After this the experience would be really similar for users with managed or custodial wallets.

@aktdenis I added the list of services inside a scrollable container, is that ok for you? My feeling was we should not let deployments with multiple (n>5) services push the modal over the limits. Here's a screenshot about:
Image

About the "Top up" question: the modal is doing multiple things already, I have a feeling adding yet another functionality would make it a bit too dense. What do you think @aktdenis @anilmurty?

@anilmurty
Copy link
Author

hey @jzsfkzm - thanks for the quick update here.
Re. combining escrow deposit into the confirm modal - makes sense - that was pretty much what I was suggesting in the description of the issue as well.
Re. limits on number of services shown without scrolling - I would say we can actually limit n<=3 before we add the scrollbar.
Re. offering option to add funds - I don't think it'll overload - it does not pop up another modal - it just redirects to stripe checkout - so it can just be a link next to the Balance link or below the amount box to the right (essentially right below the balance with the box separating them. wdyt @aktdenis ?

@baktun14
Copy link
Contributor

baktun14 commented Feb 6, 2025

We could just add a max height to the list of services with overflow auto that will add a scrollbar if necessary. I don't see a lot of deployments with more than 3 services so it's uncommon, but definitely possible.
Oh nvm looks like you did.

@jzsfkzm
Copy link
Contributor

jzsfkzm commented Feb 8, 2025

hey @jzsfkzm - offering option to add funds - I don't think it'll overload - it does not pop up another modal - it just redirects to stripe checkout - so it can just be a link next to the Balance link or below the amount box to the right (essentially right below the balance with the box separating them. wdyt @aktdenis ?

Oh, I see you now, yes, a link could work. I suppose we should render that link only below a reasonable account balance, right? Then how much would that be, $100 maybe? Text would be "Buy credits" then, I think the distinction is clear from the user's perspective.

@anilmurty
Copy link
Author

I'd say we show that all the time. Let's call it "Buy More Credits"

jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 9, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 10, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 10, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 10, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 12, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 12, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 12, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 12, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 12, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 12, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 12, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 12, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 12, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 12, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 12, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 12, 2025
jzsfkzm added a commit to jzsfkzm/console that referenced this issue Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Up Next (prioritized)
Development

No branches or pull requests

5 participants