-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow credit card users to add funds at deploy time #628
Comments
@anilmurty |
hey @aktdenis - those work but I think they may be a tad long. After thinking over this a bit, I'm thinking we leave this one as Add "Funds" and change the credit purchase one to "Buy Credits" - wdyt? - this way both are just 2 words |
hey @anilmurty, good point. it's distinguishable and works for me |
Hi there, I created a PR for this. I thought it would make sense to unify ManagedDeploymentConfirm and DeploymentDepositModal. In this change we'd be rendering the list of services on DeploymentDepositModal and use that modal for managed wallets. After this the experience would be really similar for users with managed or custodial wallets. @aktdenis I added the list of services inside a scrollable container, is that ok for you? My feeling was we should not let deployments with multiple (n>5) services push the modal over the limits. Here's a screenshot about: About the "Top up" question: the modal is doing multiple things already, I have a feeling adding yet another functionality would make it a bit too dense. What do you think @aktdenis @anilmurty? |
hey @jzsfkzm - thanks for the quick update here. |
|
Oh, I see you now, yes, a link could work. I suppose we should render that link only below a reasonable account balance, right? Then how much would that be, $100 maybe? Text would be "Buy credits" then, I think the distinction is clear from the user's perspective. |
I'd say we show that all the time. Let's call it "Buy More Credits" |
Problem Statement
Deployments created by credit card users default to $5 in the escrow, which (depending on resources leased) can sometimes allow the deployment to run for only a few minutes. Users have the option to "Add Funds" but sometimes forget to do so and have their lease closed.
Proposed Solution
Allow credit card users to optionally add/ increase the funds that go into escrow at deploy time.
The changes would be
Show a text box (similar to the one we show for wallet users) where a default value of $5 is populated and the user has the option of increasing it. This would be added under the resources box shown below

Check credit balance to ensure there are funds to fund the escrow account.
Give user the option to purchase more funds
One thing I realized @aktdenis @baktun14 @ygrishajev is that we call both "Adding funds to the account" and "adding funds to the deployment" as "Add Funds" - we may need some distinction between the two
The text was updated successfully, but these errors were encountered: