Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added icons to menu item Network (dropdown) #214

Closed
wants to merge 12 commits into from

Conversation

hiroyukikumazawa
Copy link
Contributor

for the issue #34

@hiroyukikumazawa
Copy link
Contributor Author

we can review here
http://65.109.84.205:4321/

@aktdenis
Copy link

thanks @hiroyukikumazawa appreciate your effort, but we would need to use different icons. i believe we used these across the website; https://github.com/iconoir-icons/iconoir

cc @HoomanHQ

@hiroyukikumazawa
Copy link
Contributor Author

@aktdenis
I can't see any icons of https://github.com/iconoir-icons/iconoir
otherwise I can see @heroicons/react - https://heroicons.com/
May I use this?

@aktdenis
Copy link

@hiroyukikumazawa you're right, sorry. i know we've been talking about these two sets. feel free to use heroicons

@hiroyukikumazawa
Copy link
Contributor Author

http://65.109.84.205:4321/
Please check again here @HoomanHQ, @aktdenis

@hiroyukikumazawa
Copy link
Contributor Author

Before:
image

After:
image

@HoomanDigital HoomanDigital requested a review from aktdenis June 21, 2024 04:01
@aktdenis
Copy link

@hiroyukikumazawa thank you for you effort. as we discussed here - there are several issues to resurface some of the pages on the website - we need to rethink the whole menu experience. i'll provide a draft and combine related issues into one

@hiroyukikumazawa
Copy link
Contributor Author

@hiroyukikumazawa thank you for you effort. as we discussed here - there are several issues to resurface some of the pages on the website - we need to rethink the whole menu experience. i'll provide a draft and combine related issues into one

ok

@hiroyukikumazawa
Copy link
Contributor Author

ok, please let me know if there is any updates

@HoomanDigital
Copy link

closing this now due to irrelevancy and plan to revamp everything going forward. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants