Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guides 2 #357

Merged
merged 18 commits into from
Oct 16, 2024
Merged

Guides 2 #357

merged 18 commits into from
Oct 16, 2024

Conversation

oiclid
Copy link
Contributor

@oiclid oiclid commented Aug 30, 2024

No description provided.

@HoomanDgtl
Copy link
Contributor

under review

Copy link
Contributor

@andy108369 andy108369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Branch conflicts need to be resolved though before it can be merged.

@HoomanDgtl
Copy link
Contributor

@oiclid could you please resolve the conflicts

@HoomanDgtl
Copy link
Contributor

@oiclid : are you still active on this PR?

thanks

@oiclid
Copy link
Contributor Author

oiclid commented Oct 14, 2024

@HoomanDgtl @andy108369 Sorry, I was not reading my notifications. Let me fix it.

@oiclid
Copy link
Contributor Author

oiclid commented Oct 16, 2024

@HoomanDgtl @andy108369 Done

Copy link
Contributor

@andy108369 andy108369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HoomanDgtl looks good for merging.

@HoomanDgtl
Copy link
Contributor

HoomanDgtl commented Oct 16, 2024

There is build error on this PR:
image

@HoomanDgtl HoomanDgtl merged commit ff485c6 into akash-network:main Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants