Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the search by version #563

Merged
merged 2 commits into from
May 25, 2020
Merged

Fix the search by version #563

merged 2 commits into from
May 25, 2020

Conversation

NolwennP
Copy link
Contributor

@NolwennP NolwennP commented Apr 27, 2020 •
edited
Loading

There is a bug when you search over the Serenity version of the doc. It shows also the v3 version of the doc in Serenity.

That should fix it. What do you think @bgouraud?

@NolwennP NolwennP requested a review from bgouraud April 27, 2020 09:54
bgouraud
bgouraud reviewed May 4, 2020
View reviewed changes
Copy link
Contributor

@bgouraud bgouraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to also change line 8: <meta name="docsearch:solution" content="pimv3">

bgouraud
bgouraud approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@bgouraud bgouraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM

@NolwennP NolwennP merged commit 8dfc4d0 into master May 25, 2020
@NolwennP NolwennP deleted the fix-search-by-version branch May 25, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgouraud bgouraud bgouraud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NolwennP @bgouraud