Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertical: true with "unslick" mode make big height of box (empty space) #1930

Open
mixalbl4-127 opened this issue Nov 20, 2020 · 4 comments
Open

Comments

@mixalbl4-127
Copy link

mixalbl4-127 commented Nov 20, 2020

image

Example: https://codesandbox.io/s/react-slick-playground-forked-jcn3k?file=/index.js

This bug because:

  1. Missed style: listStyle here (slick-list without any limit):
    if (this.props.unslick) {
      listProps = { className: "slick-list" };
      innerSliderProps = { className };
    }
  1. Wrong calculation here for vertical && unslick, because no cloned items here:
const trackChildren = spec.slideCount + 2 * spec.slidesToShow;
mixalbl4-127 pushed a commit to mixalbl4-127/react-slick that referenced this issue Nov 20, 2020
@mixalbl4-127
Copy link
Author

@akiran check this pull please

@vmarcel
Copy link

vmarcel commented Jan 6, 2021

Please check this pull request. We need this change soon

@shumpaga
Copy link

shumpaga commented Feb 9, 2021

Also waiting for this ⏳

@Nihal-10
Copy link

i am facing same issue any solutions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants