Component refactor #587
Closed
Component refactor #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Components are relatively fast now, while still retaining some level of ease of mutation.
This required some core changes to goo.canvasitems (wrapping).
mbfraga
force-pushed
the
wip/component_refactor
branch
from
f236fc6 to
e14f3d3
Compare
mbfraga
force-pushed
the
wip/component_refactor
branch
from
562b9b1 to
0779b34
Compare
mbfraga
force-pushed
the
wip/component_refactor
branch
from
0779b34 to
6656d50
Compare
Also added code for flipping objects.
Cleanup and more properties instead of methods.
mbfraga
force-pushed
the
wip/component_refactor
branch
from
20145ca to
bbffc15
Compare
Copy now uses a Model that enables easy recursion. Make marking dirty a bit less manual, and add more events to the model instead of items.
Also implemented group rotation (with multi-selection as well.
|
No longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary / How this PR fixes the problem?
Large refactor meant to separate view / model.
An architecture for a model was built up.
Some details:
Steps to Test
When disabled, make sure everything in Akira works correctly. Then enable the new components.
To enable: set Window.vala 's
use_new_componentto true and rebuild.Known Issues / Things To Do
WIP, a lot of things to do.