Use Scala 2.13 (drop Scala 2.12) #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ennru
commented
Dec 23, 2021
ennru
commented
- Scala 2.13 only
- Fix more compiler warnings
- Update readme
ennru
force-pushed
the
ennru-drop-scala-2.12
branch
from
083018e to
b72e513
Compare
ennru
force-pushed
the
ennru-drop-scala-2.12
branch
from
b72e513 to
ab3a13b
Compare
ennru
force-pushed
the
ennru-drop-scala-2.12
branch
from
ab3a13b to
affcb97
Compare
johanandren
approved these changes
Jan 13, 2022
| @@ -167,6 +167,7 @@ private final class CommittingProducerSinkStageLogic[K, V, IN <: Envelope[K, V, | |||
|
|
|||
| override protected def onTimer(timerKey: Any): Unit = timerKey match { | |||
| case CommittingProducerSinkStage.CommitNow => commit(Interval) | |||
| case _ => | |||
There was a problem hiding this comment.
would be good to throw to avoid potential future foot-shooting/head-scratching
There was a problem hiding this comment.
Right, I added more logging/errors for unexpected matches.
Merged
ennru
pushed a commit
that referenced
this pull request
Sep 20, 2022
* because it has ripple effect to Alpakka and then Cassandra plugin * we need to coordinate this decision across all Akka projects, later Reverts parts of #1448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.