Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalafmt: don't remove redundant braces #972

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Conversation

ennru
Copy link
Member

@ennru ennru commented Nov 18, 2019

Purpose

Don't let Scalafmt remove braces that are not strictly necessary (eg. around one-expression methods).

References

Aligned with akka/alpakka#2016

Changes

  • Use the latest sbt-plugin
  • Up the version in the config to 2.1.0 (triggered a little reindentation)
  • Remove RedundantBraces rewriting

Background Context

The removing of braces has annoyed me for some time...

@ennru ennru removed the core label Nov 18, 2019
@ennru ennru requested a review from seglo November 19, 2019 07:21
@seglo
Copy link
Contributor

seglo commented Nov 19, 2019

New (unrelated?) failure
#973

Copy link
Contributor

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seglo seglo merged commit f10f2dc into akka:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants