Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDb: AWS SDK2; Add tryFlow to be used with RetryFlow #1896

Merged
merged 4 commits into from
Sep 6, 2019

Conversation

2m
Copy link
Contributor

@2m 2m commented Aug 19, 2019

This is a continuation of #1876. Built on top of #1725 and therefore Draft until it gets merged

Purpose

Adds a DynamoDb.tryFlow of the shape Req => Try[Resp]. This allows composition with a RetryFlow (akka/akka#27461).

To let the tests pass, RetryFlow is now included verbatim in this PR.

References

Supersedes #1712
Fixes #1682

@probot-autolabeler probot-autolabeler bot added dependency-change For PRs changing the version of a dependency. documentation p:dynamodb labels Aug 19, 2019
@2m 2m force-pushed the wip-dynamo-sdk2-try-flow-2m branch from c6ccf55 to 1fec7ed Compare August 20, 2019 06:31
@2m 2m marked this pull request as ready for review August 20, 2019 06:31
@2m 2m removed dependency-change For PRs changing the version of a dependency. documentation labels Aug 20, 2019
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to put things into more context.

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru changed the title Add DynamoDb tryFlow to be used with RetryFlow and AWS SDK2 DynamoDb: AWS SDK2; Add tryFlow to be used with RetryFlow Sep 6, 2019
@ennru ennru merged commit e5303b8 into akka:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB: InternalServerErrorException: Internal server Error
2 participants