Switch from 'cut' to 'head'; cut isn't doing what it should here #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the comment on line 66-67, the
cut
command is supposed to just grab the first 1024 bytes of the file and pass that toawk
. Instead, the cut does... something else. I didn't bother figuring out what, but here's some tests that paint the picture:cut
command chops out some of the file, sure, but not the intended portion (>95% of the file remains) and for my (large) file, it takes 33 seconds to do so.cat
in the second command is 10x faster than the cut, completing in 3.5 seconds and containing the entire file.head
instead, you get the intended first 1024 bytes and the command completes effectively instantly.This commit moves away from
cut
to thehead
command, which accomplishes the intended file slice and improves performance (particularly on large files).