-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: adds support for phoenix 1.7 #192
Conversation
This is absolutely necessary for those who want to upgrade their installation to phoenix 1.7. |
bump |
bump from me too - what's the hold-up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bumping this:
plug_cowboy
2.6 adds support for websockets- tested the upgrades in a Phoenix 1.6 setup and didn't find any issues
@@ -51,7 +60,7 @@ defmodule PromEx.MixProject do | |||
{:telemetry_poller, "~> 1.0"}, | |||
{:telemetry_metrics, "~> 0.6"}, | |||
{:telemetry_metrics_prometheus_core, "~> 1.0"}, | |||
{:plug_cowboy, "~> 2.5.1"}, | |||
{:plug_cowboy, "~> 2.6"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that we could use or
to be safe:
{:plug_cowboy, "~> 2.5.1 or ~> 2.6"},
Sorry for the delay. Been dealing with some health emergencies lately. Will try and merge #184 in this weekend and will cut a release. |
fixes #191
Change description
Bumps plug_cowboy to support Phoenix 1.7
What problem does this solve?
Issue number: #191
Example usage
Additional details and screenshots
Checklist
Cant verify as some unit tests also busted on
master
too: