Phoenix Plugin: Correctly support multiple endpoints #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
The current logic for the
keep_endpoint_metrics
function doesn't work for cases where multiple endpoints are configured using theendpoints:
key.This change normalizes the endpoints config to work with
module in phoenix_endpoints
What problem does this solve?
The events defined in the
endpoint_info
function weren't working as expected, as thekeep_function_filter
returned false. This started happening after I tested out the config for multiple endpoints.Checklist