Fix _isPanelOpen/_isPanelClosed not updating their state properly #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiquidPL
force-pushed
the
fix-is-panel-open-closed-state
branch
from
0d46033 to
9c92518
Compare
LiquidPL
changed the title
|
@LiquidPL This is a wonderful PR. |
|
@LiquidPL Why is this happening when it's a getter? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since those getters depend on the animation controller, they never triggered a rebuild whenever the panel was opened/closed, causing a bug where the collapsed widget was still receiving pointer events when the panel is open.