Add support for options #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support to ignore_getters_and_setter options so ecma6 that have virtual properties that located in the schema will work
aksyonov
requested changes
Apr 29, 2017
| @@ -1,2 +1,2 @@ | |||
| declare function loadClass(schema: any, target: any): void; | |||
| declare function loadClass(schema: any, {target: any,options: object}:object): void; | |||
There was a problem hiding this comment.
Will this work when developer uses it without options, like loadClass(schema, UserModel);?
There was a problem hiding this comment.
Yes I kept on backward compatibility
README.md
Outdated
| @@ -58,8 +58,13 @@ class UserModel { | |||
|
|
|||
| } | |||
|
|
|||
| //posible options, for instance if you want to ignore getter and setters put | |||
| options={ | |||
| ignore_getters_and_setters:true | |||
There was a problem hiding this comment.
Please name options in camelCase, also use let or const for declaring options here.
src/index.js
Outdated
| @@ -1,6 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| function wrap(schema, target, hooks = []) { | |||
| function wrap(schema,params, hooks = []) { | |||
| let {options={},target=params} = params; | |||
There was a problem hiding this comment.
Please make your code consistent with existing code (add space after , and :, around =, use 2 spaces for indentation).
|
Fixed the request changes |
aksyonov
approved these changes
May 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support to ignore_getters_and_setter options so ecma6 that have
virtual properties that located in the schema will work
for instance if you have class
will throw an exception , let's let the user to decide if s/he wants to add virtual prorties or not