-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NbDialogService
has problem with inputSignal
and ModelSignal
#3256
Comments
junglerobba
added a commit
to junglerobba/nebular
that referenced
this issue
Jan 31, 2025
This makes an exception for input and model signals in the DialogConfig context, so the typehint will show as the type of the signal's value, but internally it will create a signal with the passed value. Technically these will just be readonly signals instead of input or model signals, but since components used as a dialog do not support regular outputs anyway, it should not matter. When used in a regular context the input signal will not be overwritten and work as usual. closes akveo#3256 (I would not classify this as a bug but a missing feature instead)
junglerobba
added a commit
to junglerobba/nebular
that referenced
this issue
Jan 31, 2025
This makes an exception for input and model signals in the DialogConfig context, so the typehint will show as the type of the signal's value, but internally it will create a signal with the passed value. Technically these will just be readonly signals instead of input or model signals, but since components used as a dialog do not support regular outputs anyway, it should not matter. When used in a regular context the input signal will not be overwritten and work as usual. closes akveo#3256 (I would not classify this as a bug but a missing feature instead)
1 task
junglerobba
added a commit
to junglerobba/nebular
that referenced
this issue
Feb 16, 2025
This makes an exception for input and model signals in the DialogConfig context, so the typehint will show as the type of the signal's value, but internally it will create a signal with the passed value. Technically these will just be readonly signals instead of input or model signals, but since components used as a dialog do not support regular outputs anyway, it should not matter. When used in a regular context the input signal will not be overwritten and work as usual. closes akveo#3256 (I would not classify this as a bug but a missing feature instead)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue type
I'm submitting a ...
Issue description
Current behavior:
Expected behavior:
The input model should be updated, not tried to be replaced by new value
Steps to reproduce:
inputSignal
(input.required()
);context
specifying ourinputSignal
Related code:
Other information:
npm, node, OS, Browser
Angular, Nebular
The text was updated successfully, but these errors were encountered: