Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize logo lay-out of keywords #1855

Closed
lauraroverts opened this issue Oct 9, 2015 · 5 comments · Fixed by #1977
Closed

Optimize logo lay-out of keywords #1855

lauraroverts opened this issue Oct 9, 2015 · 5 comments · Fixed by #1977
Assignees
@gabemart
Labels
Type: Akvo Pages
Milestone
3.10 Nouakchott

Comments

@lauraroverts
Copy link

Test plan

GIVEN the project page
WHEN a project has 2 or more keywords with a logo attached
THEN two logos should be shown in the project header
AND they should be horizontally aligned
AND there should be spacing in between the two logos

Issue description

At Akvo Pages you can now show 2 logos, e.g. http://aquaforall.akvoapp.org/en/project/3322/
But it doesn't look very nice.

screen shot 2015-10-09 at 15 32 57
@KasperBrandt KasperBrandt modified the milestone: 3.10 Nouakchott Oct 26, 2015
@KasperBrandt KasperBrandt modified the milestone: 3.11 Ouagadougou Dec 28, 2015
@lauraroverts
Copy link
Author

This might also influence #1948

@lauraroverts lauraroverts added this to the 3.10 Nouakchott milestone Dec 28, 2015
@KasperBrandt KasperBrandt self-assigned this Jan 6, 2016
@KasperBrandt KasperBrandt added Ready and removed Backlog labels Jan 6, 2016
gabemart added a commit that referenced this issue Jan 15, 2016
@gabemart
[#1855] Style project page logos for Akvo Pages
ee99250
@kardan kardan added In Progress and removed Ready labels Jan 15, 2016
@gabemart
Copy link
Contributor

@lauraroverts I suggest it is enough to just align the logos evenly in this case

image

@gabemart gabemart mentioned this issue Jan 15, 2016
Merged
@lauraroverts
Copy link
Author

Wouldn't ik look better to display the logos next to each other? Otherwise this is okay.

@KasperBrandt
Copy link
Contributor

Yeah, maybe that's nicer indeed 👍, could you have a go at that @gabemart?

gabemart added a commit that referenced this issue Jan 19, 2016
@gabemart
[#1855] Display project logos inline
c36d222
@gabemart
Copy link
Contributor

image

👍

KasperBrandt added a commit that referenced this issue Jan 19, 2016
@KasperBrandt
Merge pull request #1977 from akvo/#1855-logo-layout
0b71dae 
[#1855] Style project page logos for Akvo Pages
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabemart gabemart

Labels
Type: Akvo Pages
Projects
RSR
Archived in project
Milestone
3.10 Nouakchott
Development

Successfully merging a pull request may close this issue.

[#1855] Style project page logos for Akvo Pages akvo/akvo-rsr
4 participants
@kardan @KasperBrandt @gabemart @lauraroverts