Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into performance of Tastypie #2262

Closed
KasperBrandt opened this issue Jun 27, 2016 · 2 comments
Closed

Look into performance of Tastypie #2262

KasperBrandt opened this issue Jun 27, 2016 · 2 comments

Comments

@KasperBrandt
Copy link
Contributor

We should look into the Tastypie API and see whether it causes some of RSR's performance issues.

@damienallen
Copy link
Contributor

damienallen commented Jun 27, 2016

Calls to the old API can result in unfiltered queries for all projects and/or users. The following line is one likely source (akvo/api/fields.py line 98):

foreign_obj = getattr(bundle.obj, self.attribute)

@KasperBrandt
Copy link
Contributor Author

KasperBrandt commented Jul 6, 2016

Test plan

  • Compare the /api/v1/ output to the one from Live/UAT/Test, it should contain the same fields, definitely for the project and project_update endpoints. (One exception: offset is not supported in DRF, so that has been removed)
    • For format=xml
    • For format=json
    • Check that format=html (default) also reflects the same data as the other outputs. This was not supported before by Tastypie, but should still show the same data.
  • Check that the /api/v1/right_now_in_akvo/?format=json returns the same as before on Test/UAT/Live (see Replicate right_now_in_akvo API endpoint in the DRF API #1636).

damienallen added a commit that referenced this issue Jul 14, 2016
[#2262] Remove Tastypie and convert old links to DRF
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants