Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links not clickable on Pages (Partner sites) project updates #438

Closed
osg74 opened this issue Jan 29, 2014 · 5 comments
Closed

Links not clickable on Pages (Partner sites) project updates #438

osg74 opened this issue Jan 29, 2014 · 5 comments
Assignees
@kardan
Labels
Bug Type: Permissions
Milestone
2.3.4 Tamarine

Comments

@osg74
Copy link

osg74 commented Jan 29, 2014

Links aren't clickable on Pages versions of project updates, e.g. in RSR we see the link as expected http://rsr.akvo.org/project/352/update/4545/, whereas the Pages version only has the link text: http://connect4change.akvoapp.org/en/project/352/update/4545/
@ghost ghost assigned zzgvh Jan 29, 2014
@kardan
Copy link
Contributor

kardan commented Jan 30, 2014

From a quick review it looks like we miss some "|urlize" see https://github.com/akvo/akvo-rsr/blob/develop/akvo/templates/rsr/project/project_update.html#L67
The template filter should be at least on
https://github.com/akvo/akvo-rsr/blob/develop/akvo/templates/rsr/project/project_update.html#L91
https://github.com/akvo/akvo-rsr/blob/develop/akvo/templates/partner_sites/project/update_main.html#L126
https://github.com/akvo/akvo-rsr/blob/develop/akvo/templates/partner_sites/project/update_main.html#L154

But probably at other texts as well.

@ghost ghost assigned kardan Jan 30, 2014
kardan added a commit that referenced this issue Jan 31, 2014
@kardan
[#438] Links in updates are urlized
15e9dbd 
If a link is present in the markdown update, but not marked
as a proper link we use the urlize template tag to create a
link from the url. This link will show the full url as the link

We do not urlize texts that are limited in chars. Examples of this
is the project list and the small preview on the main project page.
The motivation for this is that it might be unsafe to deal with.
@kardan
Copy link
Contributor

kardan commented Jan 31, 2014

@zzgvh can you review #439 ?

@kardan
Copy link
Contributor

kardan commented Feb 5, 2014

This change should also fix the problem in #419

@kardan kardan mentioned this issue Feb 5, 2014
Closed
@kardan
Copy link
Contributor

kardan commented Feb 5, 2014

Instead of only converting update text from markdown we also scan the update text for urls and make them into links. In mark down you should really use the description syntax.

zzgvh added a commit that referenced this issue Feb 10, 2014
@zzgvh
Merge pull request #439 from akvo/feature/438-urlize-updates
bfda030 
[#438] Links in updates are urlized
@rumca rumca added Bug labels Mar 10, 2014
@rumca
Copy link
Contributor

rumca commented Mar 10, 2014

Tested on UAT and PartnerSite UAT - working as expected

@rumca rumca closed this as completed Mar 10, 2014
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kardan kardan

Labels
Bug Type: Permissions
Projects
RSR
Archived in project
Milestone
2.3.4 Tamarine
Development

No branches or pull requests
5 participants
@kardan @zzgvh @osg74 @adriancollier @rumca