Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ProjectAdmin.add_view() for 1.5 #566

Closed
zzgvh opened this issue May 20, 2014 · 2 comments
Closed

Fix ProjectAdmin.add_view() for 1.5 #566

zzgvh opened this issue May 20, 2014 · 2 comments
Milestone
2.3.8 Xylocarp

Comments

@zzgvh
Copy link
Contributor

zzgvh commented May 20, 2014

See item 3 in #545. This should be part of the upgrade to 1.5 however, it's not something that should go in before the first step upgrade.
zzgvh added a commit that referenced this issue May 20, 2014
@zzgvh
[#566] Fix ProjectAdmin.add_view() to match 1.5
6306b3e 
ProjectAdmin.add_view() is overridden to add functionality to the admin
form. For this reason it's necessary to check that the "original" code
matches the version of django we're running on. This is now fixed for
Django 1.5.
zzgvh added a commit that referenced this issue May 20, 2014
@zzgvh
[#566] Cleanup of rsr/admin.py
dcf77f1 
Remove unused imports and old commented out code.
@adriancollier adriancollier added this to the 2.3.8 Xylocarp milestone Jun 3, 2014
zzgvh added a commit that referenced this issue Jun 4, 2014
@zzgvh
[#566] Merge branch 'feature/django-upgrade' into feature/566_fix_add…
c593cd7 
…_view_for_1.5

Conflicts:
	akvo/rsr/admin.py

Checked ProjectAdmin.add_vew for compatibility with Django 1.6
zzgvh added a commit that referenced this issue Jun 4, 2014
@zzgvh
[#566] Remove part of admin.py accidentally added from old code
9f53b67
zzgvh added a commit that referenced this issue Jun 4, 2014
@zzgvh
[#566] Missed one bit and realized that partner_clean() is old code too
95743a3
KasperBrandt added a commit that referenced this issue Jun 4, 2014
@KasperBrandt
Merge pull request #606 from akvo/feature/566_fix_add_view_for_1.5
1edf844 
[#566] Fix ProjectAdmin.add_view() to match 1.5 and 1.6
@KasperBrandt
Copy link
Contributor

Merged in #606

@zzgvh
Copy link
Contributor Author

zzgvh commented Jun 10, 2014

@rumca Test plan: Check that new Projects can be created normally. In the empty form for a new project the user's organisation should be pre-selected in the Partners section. Also when you create a project via the "Save as new" button, thus creating a copy, the inline objects for location and benchmarks should not be included in the new project.

@zzgvh zzgvh reopened this Jun 10, 2014
@zzgvh zzgvh closed this as completed Jun 10, 2014
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
RSR
Archived in project
Milestone
2.3.8 Xylocarp
Development

No branches or pull requests
3 participants
@zzgvh @adriancollier @KasperBrandt