Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProjectComment time field should auto generate #659

Closed
zzgvh opened this issue Jul 1, 2014 · 2 comments
Closed

ProjectComment time field should auto generate #659

zzgvh opened this issue Jul 1, 2014 · 2 comments
Assignees
@KasperBrandt
Labels
Type: Permissions
Milestone
2.4 Astana

Comments

@zzgvh
Copy link
Contributor

zzgvh commented Jul 1, 2014

ProjectComment shoud be refactored using the TimestampsMixin in a similar way that it's used in Project etc. The direct reason for this is that currently you have to supply the time when creating a comment through the API and that's clearly wrong.
@adriancollier adriancollier added this to the 2.3.10 Zambo milestone Jul 1, 2014
@KasperBrandt KasperBrandt self-assigned this Jul 23, 2014
@KasperBrandt KasperBrandt modified the milestones: 2.4 Astana, 2.3.10 Zambo Jul 25, 2014
KasperBrandt added a commit that referenced this issue Jul 29, 2014
@KasperBrandt
[#659] Added TimestampsMixin to ProjectComment model and admin
c3c3b19
KasperBrandt added a commit that referenced this issue Jul 29, 2014
@KasperBrandt
[#659] Merge branch 'develop' into feature/659_comment_datetime
b7aa61e
KasperBrandt added a commit that referenced this issue Aug 5, 2014
@KasperBrandt
[#659] Merge branch 'develop' into feature/659_comment_datetime
731b4b3
KasperBrandt added a commit that referenced this issue Aug 5, 2014
@KasperBrandt
[#659] Updated migrations of project comment datetime
e091a89
KasperBrandt added a commit that referenced this issue Aug 6, 2014
@KasperBrandt
[#659] Merge branch 'develop' into feature/659_comment_datetime
8f58b9b
KasperBrandt added a commit that referenced this issue Aug 6, 2014
@KasperBrandt
[#659] Updated migrations
35b2724
KasperBrandt added a commit that referenced this issue Aug 6, 2014
@KasperBrandt
[#659] Updated comment.time to comment.created_at in templates and views
912ec71
zzgvh added a commit that referenced this issue Aug 11, 2014
@zzgvh
Merge pull request #707 from akvo/feature/659_comment_datetime
465c0e6 
[#659] Added created_at and last_modified_at to project comments
@KasperBrandt
Copy link
Contributor

Merged in #707

@rumca
Copy link
Contributor

rumca commented Aug 29, 2014

tested this through the admin (not sure how to test with API) and works fine

@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KasperBrandt KasperBrandt

Labels
Type: Permissions
Projects
RSR
Archived in project
Milestone
2.4 Astana
Development

No branches or pull requests
4 participants
@zzgvh @adriancollier @KasperBrandt @rumca