[#1785] Cached API results of local storage #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a try, except clause to make sure that we don't try to store the API results to the local storage if there is not enough space in the local storage.
Checklist
|
kardan
added a commit
that referenced
this pull request
Sep 1, 2015
[#1785] Cached API results of local storage
|
To test this one would have to fill up local storage (how to and with how much depends on the browser used to test the feature). No docs is needed since it so small and hopefully a corner case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1785
Added a try, except clause to make sure that we don't try to store the API results to the local storage if there is not enough space in the local storage.