[#479] Modified the markup and style to match requested visual changes #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes looks fine, but we need to pack new assets file with the packer.py script. It does look like there is a bug when the packer.py script don't find a ./build dir next to the src. As a workaround the directory "akvo/mediaroot/partner_sites/js/build" could be added manually. Once that is done from the repo root issue: |
kardan
added a commit
that referenced
this pull request
Mar 27, 2014
[#479] Modified the markup and style to match requested visual changes
|
Code reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kardan Can you code check?