Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyError exception for nested resource during generate swagger. #228

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

jeffrey4l
Copy link
Contributor

This patch fix bug #227

@alanjds
Copy link
Owner

alanjds commented May 5, 2021

Thanks for reporting and for the bugfix, @jeffrey4l.

As soon as the CI tests get green, this will be merged.

It can take a while to be published to PyPI, as I usually let stuff hanging on master to see if someone reports regressions. Yet this PR is very simple, so feel free to ask for a patch release if you need to pull from PyPI. I would rather not do it right now.

@jeffrey4l
Copy link
Contributor Author

@alanjds i am the first-time to contribute this project, seem need a maintainer approve this workflow. Cloud you help for this?

First-time contributors need a maintainer to approve running workflows. Learn more.

@jeffrey4l
Copy link
Contributor Author

anybody could approve this patch?

@jeffrey4l
Copy link
Contributor Author

bump

@alanjds
Copy link
Owner

alanjds commented Aug 26, 2021

This is odd. Why are the tests never passed or failed 🤔 ?

@alanjds
Copy link
Owner

alanjds commented Aug 26, 2021

Still odd, the stuff shown on the official docs does not show up for me. See:
image

Am approving without tests, as the change seems innocuous, and if it breaks master we will see.

@alanjds i am the first-time to contribute this project, seem need a maintainer approve this workflow. Cloud you help for this?

First-time contributors need a maintainer to approve running workflows. Learn more.

@alanjds alanjds merged commit 06e2bcd into alanjds:master Aug 26, 2021
@alanjds
Copy link
Owner

alanjds commented Aug 26, 2021

Thanks @jeffrey4l for the contribution and bug report. Sorry for the delayed response.

@jeffrey4l
Copy link
Contributor Author

thanks @alanjds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants