Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add flag to run "apt-get autoremove" after patching on ubuntu servers #149

Closed
jonasbartho opened this issue Aug 20, 2019 · 2 comments
Closed

add flag to run "apt-get autoremove" after patching on ubuntu servers #149

jonasbartho opened this issue Aug 20, 2019 · 2 comments
Assignees
@albatrossflavour
Labels
enhancement New feature or request feature pending testing

Comments

@jonasbartho
Copy link

Is your feature request related to a problem? Please describe.
Problem on Ubuntu is that is doesn't clean up old kernels automatically. Having a feature in this module to clean up old kernels would be super handy.

Describe the solution you'd like
A flag that can run "apt-get autoremove" after patching Ubuntu servers.

Describe alternatives you've considered
running "apt-get autoremove" through a cron job the day after patching.

Additional context
Be aware that apt-get autoremove only should run in 2 cases:

  1. if no new kernel is installed within the patching round
  2. if patching included a new kernel + needs a reboot, apt-autoremove should run after that reboot, not immediately after patching

!!! apt-get autoremove can remove the running kernel when the system is booted with an old kernel
!!! apt-get autoremove doesn't only remove old kernels, it also removes old dependencies that aren't necessary anymore
albatrossflavour pushed a commit that referenced this issue Aug 20, 2019
#149 try both ways of doing the autoremove
5d81dc0
albatrossflavour pushed a commit that referenced this issue Aug 20, 2019
#149 fix default
1f82647
albatrossflavour pushed a commit that referenced this issue Aug 20, 2019
#149 fix default
a565681
albatrossflavour pushed a commit that referenced this issue Aug 20, 2019
#149 allow cron job to be removed
b347c5d
albatrossflavour pushed a commit that referenced this issue Aug 20, 2019
#149 revert changes to the task now that we are doing the autoremove …
565bcd0 
…via cron
@albatrossflavour albatrossflavour self-assigned this Aug 20, 2019
@albatrossflavour albatrossflavour added enhancement New feature or request feature labels Aug 20, 2019
@albatrossflavour
Copy link
Owner

After talking to @jonasbartho we decided that an update to the manifest to allow an @reboot cron job which runs apt-get -y autoremove. That code has been added in and is pending testing.

albatrossflavour pushed a commit that referenced this issue Aug 21, 2019
#149 try both ways of doing the autoremove
cb004bf
albatrossflavour pushed a commit that referenced this issue Aug 21, 2019
#149 fix default
676827d
albatrossflavour pushed a commit that referenced this issue Aug 21, 2019
#149 fix default
2953d1f
albatrossflavour pushed a commit that referenced this issue Aug 21, 2019
#149 allow cron job to be removed
6fe6203
albatrossflavour pushed a commit that referenced this issue Aug 21, 2019
#149 revert changes to the task now that we are doing the autoremove …
28f1e24 
…via cron
albatrossflavour pushed a commit that referenced this issue Aug 21, 2019
#149 allow Debian to run apt-get autoremove at reboot (#151)
d82b98a 
* Add an option to the task to allow the running of `apt-get autoremove` after patching

* #149 try both ways of doing the autoremove

* #149 fix default

* #149 fix default

* #149 allow cron job to be removed

* #149 revert changes to the task now that we are doing the autoremove via cron

* Add an option to the task to allow the running of `apt-get autoremove` after patching

* #149 try both ways of doing the autoremove

* #149 fix default

* #149 fix default

* #149 allow cron job to be removed

* #149 revert changes to the task now that we are doing the autoremove via cron
@albatrossflavour
Copy link
Owner

Complete

albatrossflavour pushed a commit that referenced this issue Aug 21, 2019
V0.12.0 release (#152)
fc23adc 
* The declared ISO format does not exist, had one extra `dd` (#141)

* Force usage of the 'C' locale (#142)

When parsing command output, we should ensure the utility will emit
messages in the language we are using for matching patterns.  Force the
locale to be 'C' by setting the LC_ALL environment variable.

* link to the wiki

* #128 additional queries as examples

* Add missing dependency (#144)

The `Exec[os_patching::exec::fact]` requires the
`${cache_dir}/reboot_override` file.

* Updates to facter and bug fixes (#148)

* #143 try a new way of doing matching for pinned packages

* Fixed typos

* #147 update the fact with the new data

* #147 fix ordering

* #147 only create the mismatch array if the file has data in it

* #147 cross linux distro compatability

* #147 sles compatability

* #145 add a list of KB updates to the fact

* Fix handling of KBArticleIDs (#146)

* Fix handling of KBArticleIDs

- Ensures all KBArticleIDs are processed, not just the first one in the array
- Ensures the ID's start with "KB", which aids reusing the fact info later on.

* fix typo in variable

typo in variable (kbslist --> kblist) on line 57

* #143 try a new way of doing matching for pinned packages

* Fixed typos

* #147 update the fact with the new data

* #147 fix ordering

* #147 only create the mismatch array if the file has data in it

* #147 cross linux distro compatability

* #147 sles compatability

* #145 add a list of KB updates to the fact

* Fix handling of KBArticleIDs (#146)

* Fix handling of KBArticleIDs

- Ensures all KBArticleIDs are processed, not just the first one in the array
- Ensures the ID's start with "KB", which aids reusing the fact info later on.

* fix typo in variable

typo in variable (kbslist --> kblist) on line 57

* Fix missing slash (#147)

* #143 Fix formatting and use puppet_vardir rather than puppet_client_datadir

* #143 change to clientcert rather than fqdn for the catalog name

* rename element to version_specified_but_not_locked_packages

* Toggle to allow warnings to block patching #143 (#150)

* #143 first stab at a new parameter to control VSBNLP behaviour

* Try the new format for the locked files

* Abort flag

* update fact

* #149 allow Debian to run `apt-get autoremove` at reboot (#151)

* Add an option to the task to allow the running of `apt-get autoremove` after patching

* #149 try both ways of doing the autoremove

* #149 fix default

* #149 fix default

* #149 allow cron job to be removed

* #149 revert changes to the task now that we are doing the autoremove via cron

* Add an option to the task to allow the running of `apt-get autoremove` after patching

* #149 try both ways of doing the autoremove

* #149 fix default

* #149 fix default

* #149 allow cron job to be removed

* #149 revert changes to the task now that we are doing the autoremove via cron

* Pre-v0.12.0 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albatrossflavour albatrossflavour

Labels
enhancement New feature or request feature pending testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@albatrossflavour @jonasbartho