-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json encoding issue #92
Comments
Any commonality on these servers? Could you send through the output
from the yum job (`yum history info` on the job). It failed on the JSON
output and the error shows a “\xE2” (circumflex). Maybe I need to
put some enforced conversation/validation in place, but it’ll help to
see the output.
…On 10 Oct 2018, at 4:15, Tommy McNeely wrote:
I received the following error on several systems (but not all?)
during our patching this morning:
```
Error: Task exited 1:
/opt/puppetlabs/puppet/lib/ruby/2.4.0/json/common.rb:286:in `encode':
"\xE2" from ASCII-8BIT to UTF-8 (Encoding::UndefinedConversionError)
from /opt/puppetlabs/puppet/lib/ruby/2.4.0/json/common.rb:286:in
`generate'
from /opt/puppetlabs/puppet/lib/ruby/2.4.0/json/common.rb:286:in
`pretty_generate'
from
/opt/puppetlabs/pxp-agent/tasks-cache/b0c0fdc92e00418c26ec72a8d74eac552b66233c733c72c2ee4357e134a97b51/patch_server.rb:87:in
`output'
from
/opt/puppetlabs/pxp-agent/tasks-cache/b0c0fdc92e00418c26ec72a8d74eac552b66233c733c72c2ee4357e134a97b51/patch_server.rb:404:in
`<main>'
```
... the updates appear to have been installed
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#92
|
|
This is a pretty hard one to test without having a system we can be sure fails. Even artificial test scenarios won't help give complete assurance. I've put in a force encoding on the standard output, that should resolve the problem. It's in branch bugfix/94_json_encoding. My testing shows that things still work, but I can't replicate the scenario you faced. I'm going to try to find a package with an accent in the name and test with that, but if you're able to try again, let me know how you go, |
Well, and the real hard part is that it doesn't actually fail. The package upgrade succeeds, so its a one time thing. I suppose we could try installing RHEL 7.2 on something and seeing if its reproducible. However, I made it "reasonably difficult" for people to provision any RHEL 7.2 boxes, and would rather not undo that :) ~tommy |
I tried to reproduce it with an array of systems, different minor
revisions of 5, 6 and 7 - no joy
…On 8 Nov 2018, at 8:56, Tommy McNeely wrote:
Well, and the real hard part is that it doesn't actually fail. The
package upgrade succeeds, so its a one time thing. I suppose we could
try installing RHEL 7.2 on something and seeing if its reproducible.
However, I made it "reasonably difficult" for people to provision any
RHEL 7.2 boxes, and would rather not undo that :)
~tommy
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#92 (comment)
|
It was from RHEL 7.2 , os_pathing yum update to 7.5 back in September... but lets just call it a fluke and close it for now. If we see it again, we can reference back to this and see what we can find out then |
Can't reproduce |
I received the following error on several systems (but not all?) during our patching this morning:
... the updates appear to have been installed
The text was updated successfully, but these errors were encountered: